Fix crash when removing a kqueue entry in response to a fs event#1
Open
MichaelBuckley wants to merge 1 commit intouliwitness:masterfrom
Open
Fix crash when removing a kqueue entry in response to a fs event#1MichaelBuckley wants to merge 1 commit intouliwitness:masterfrom
MichaelBuckley wants to merge 1 commit intouliwitness:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Uli,
This is a patch to a timing-related crash reported by some Transmit users. It only occurs because we are removing entries in response to file system events. which may not be typical usage. In this case, if there are more messages in the queue, a crash can occur if removal completes before the messages are processed.
Since this may not be a typical use case, we weren't sure if you'd want to accept this patch, but it definitely solved a problem for us, and may solve a problem for others. If you have any concerns about the implementation, I would be happy to revise it.