Skip to content

Upgrade root React hooks lint#4965

Merged
zbeyens merged 2 commits intomainfrom
codex/root-eslint-hooks-upgrade
Apr 25, 2026
Merged

Upgrade root React hooks lint#4965
zbeyens merged 2 commits intomainfrom
codex/root-eslint-hooks-upgrade

Conversation

@zbeyens
Copy link
Copy Markdown
Member

@zbeyens zbeyens commented Apr 25, 2026

Summary

  • upgrade root ESLint and react-hooks plugin
  • keep intentional React sync cases with local disables
  • merge auto-release Version Packages PRs directly with admin squash merge

Verification

  • pnpm check
  • bun test tooling/scripts/auto-release-pr.test.mjs tooling/scripts/prepare-release-changesets.test.mjs

@zbeyens zbeyens requested a review from a team April 25, 2026 20:42
@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Apr 25, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 25, 2026

⚠️ No Changeset found

Latest commit: 32a2fc6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
plate Ready Ready Preview, Comment Apr 25, 2026 8:50pm

Request Review

@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. javascript Pull requests that update javascript code maintenance labels Apr 25, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7d64ab0ced

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +80 to 82
const content = useThemedHtml(html, serverTheme);

return <iframe title="Preview" srcDoc={content} {...props} />;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve initial iframe HTML through hydration

Rendering srcDoc directly from useThemedHtml makes the first client render depend on resolvedTheme, so when the client resolves to a different theme than serverTheme (for example dark client preference vs light server HTML), the iframe markup can differ from the server output during hydration and cause mismatch/flicker. The prior state+effect flow avoided this by keeping the server HTML for the initial render and applying themed HTML after mount.

Useful? React with 👍 / 👎.

@zbeyens zbeyens merged commit be5804b into main Apr 25, 2026
5 of 6 checks passed
@zbeyens zbeyens deleted the codex/root-eslint-hooks-upgrade branch April 25, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code maintenance size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant