ASoC: soc-acpi-intel-ptl-match: add ptl_cs42l43_agg_l3_cs35l56_l12_ghost_rt722#5754
Open
bardliao wants to merge 1 commit intothesofproject:topic/sof-devfrom
Open
ASoC: soc-acpi-intel-ptl-match: add ptl_cs42l43_agg_l3_cs35l56_l12_ghost_rt722#5754bardliao wants to merge 1 commit intothesofproject:topic/sof-devfrom
bardliao wants to merge 1 commit intothesofproject:topic/sof-devfrom
Conversation
bardliao
requested review from
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
There was a problem hiding this comment.
Pull request overview
Adds a new PTL SoundWire ACPI machine match intended to handle BIOSes that advertise a “ghost” RT722/ALC722 codec _ADR even when the device is not physically present, by providing an _ADR entry with zero endpoints so the machine driver skips it.
Changes:
- Added a new cs42l43 aggregated _ADR table that includes an extra “ghost” RT722/ALC722 device with no endpoints.
- Added new cs35l56 2-amp _ADR tables using
spk_1..spk_4endpoints. - Added a new PTL SoundWire link table + machine entry wiring these pieces together.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| static const struct snd_soc_acpi_adr_device cs35l56_1_2amp_adr[] = { | ||
| { | ||
| .adr = 0x0001321fa355601ull, |
Comment on lines
+222
to
+223
| * To handle the ALC722 codec is listed in the BIOS while the hardware is not | ||
| * physically present. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+222
to
+223
| * To handle the ALC722 codec is listed in the BIOS while the hardware is not | ||
| * physically present. |
|
|
||
| static const struct snd_soc_acpi_adr_device cs35l56_1_2amp_adr[] = { | ||
| { | ||
| .adr = 0x0001321fa355601ull, |
…ost_rt722 Some BIOS include a ghost ALC722 codec ADR while the hardware is not physically present. That's why we need to create an acpi mach table with empty endpoint. The ghost ALC722 codec with empty endpoint will be skipped by the machine driver. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Closes:thesofproject#5721
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+222
to
+226
| * To handle cases where the ALC722 codec is listed in the BIOS while the | ||
| * hardware is not physically present. | ||
| */ | ||
| { | ||
| .adr = 0x000330025d072201ull, /* Ghost ALC722 */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some BIOS include a ghost ALC722 codec ADR while the hardware is not physically present. That's why we need to create an acpi mach table with empty endpoint. The ghost ALC722 codec with empty endpoint will be skipped by the machine driver.