[6.x] Fix relationship selector footer not sticking to bottom of stack#14569
Merged
jasonvarga merged 1 commit into6.xfrom Apr 29, 2026
Merged
[6.x] Fix relationship selector footer not sticking to bottom of stack#14569jasonvarga merged 1 commit into6.xfrom
jasonvarga merged 1 commit into6.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the relationship selector's footer bar (with the Select/Cancel buttons) was not fixed to the bottom of the stack, causing it to be pushed off-screen when the listing content was tall.
This was happening because the Listings refactor (#11868) replaced the old
<data-list>component with the new<Listing>component, whose root<div>doesn't have any flex properties. This meant the listing content could grow unbounded within the flex column layout, pushing the footer below the viewport.This PR fixes it by adding
flex flex-1 flex-col min-h-0to the<Listing>component so it participates in the flex layout and constrains its height, andshrink-0to the footer so it never gets compressed.Before
After
Fixes #14568