[6.x] Fix asset selector drag-to-upload covering footer but not handling drops#14551
Open
duncanmcclean wants to merge 3 commits into6.xfrom
Open
[6.x] Fix asset selector drag-to-upload covering footer but not handling drops#14551duncanmcclean wants to merge 3 commits into6.xfrom
duncanmcclean wants to merge 3 commits into6.xfrom
Conversation
jasonvarga
reviewed
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where dragging a file onto the asset selector flyout's footer area would open the file in a new browser tab instead of uploading it, and leave the "Drop File to Upload" overlay stuck.
This was happening because the drag-to-upload overlay used
absolute inset-0which visually covered the entire stack (including the footer), but the actual drop handler only existed on theUploadercomponent wrapping the browser content — not the footer. Dropping on the footer had no handler to callpreventDefault(), so the browser's default behavior kicked in.This PR fixes it by moving the
Uploaderwrapper from inside theBrowsercomponent up to theSelectorcomponent, so it wraps the entire flyout content including the footer. When an external uploader is provided to theBrowser, its internal one is disabled (drag events are unbound so they bubble up to the parent). The standalone asset browser page is unaffected since it still uses its own internal uploader.An alternate approach would be to confine the overlay to the stack's content area so it doesn't lay on top of the footer, but making the whole stack droppable felt like the better UX.
Fixes #14536