Skip to content

Changing AgentState.response -> AgentState.messages#743

Open
splunk-dtaborski wants to merge 2 commits intodevelopfrom
change-agentstate-response-to-messages
Open

Changing AgentState.response -> AgentState.messages#743
splunk-dtaborski wants to merge 2 commits intodevelopfrom
change-agentstate-response-to-messages

Conversation

@splunk-dtaborski
Copy link
Copy Markdown

No description provided.

Comment thread splunklib/ai/engines/langchain.py
Comment on lines +523 to +525
assert isinstance(
resp.result, SubagentFailureResult
), "subagent call did not fail"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a couple of formatting changes are included in this PR as well, make sure you're using ruff

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for example formatting a file: uv run ruff format --force-exclude splunklib/ai/base_agent.py.

sorting imports: uv run ruff check --fix --force-exclude --select=I001 --exit-zero --no-cache

though IIRC not all files in the repo are properly formatted yet, we wanted to make it after merging to public repo, so for the time being make sure to format only the files you're changing.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll consider adding makefile targets for formatting to make lifes easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants