Changing AgentState.response -> AgentState.messages#743
Open
splunk-dtaborski wants to merge 2 commits intodevelopfrom
Open
Changing AgentState.response -> AgentState.messages#743splunk-dtaborski wants to merge 2 commits intodevelopfrom
splunk-dtaborski wants to merge 2 commits intodevelopfrom
Conversation
Ickerday
reviewed
Apr 24, 2026
szykol
reviewed
Apr 24, 2026
Comment on lines
+523
to
+525
| assert isinstance( | ||
| resp.result, SubagentFailureResult | ||
| ), "subagent call did not fail" |
Collaborator
There was a problem hiding this comment.
looks like a couple of formatting changes are included in this PR as well, make sure you're using ruff
Collaborator
There was a problem hiding this comment.
for example formatting a file: uv run ruff format --force-exclude splunklib/ai/base_agent.py.
sorting imports: uv run ruff check --fix --force-exclude --select=I001 --exit-zero --no-cache
though IIRC not all files in the repo are properly formatted yet, we wanted to make it after merging to public repo, so for the time being make sure to format only the files you're changing.
Collaborator
There was a problem hiding this comment.
We'll consider adding makefile targets for formatting to make lifes easier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.