Skip to content

fix(selectors): enable search on all picker and selector subBlocks#4269

Merged
waleedlatif1 merged 1 commit intostagingfrom
fix/pickers
Apr 23, 2026
Merged

fix(selectors): enable search on all picker and selector subBlocks#4269
waleedlatif1 merged 1 commit intostagingfrom
fix/pickers

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • Removed selectorAllowSearch: false from 31 selector subBlocks across 18 integration blocks
  • Affected: Airtable, Asana, Attio, Cal.com, Confluence, Google BigQuery, Google Calendar, Google Sheets, Google Tasks, Jira Service Management, Microsoft Excel, Microsoft Planner, Microsoft Teams, Notion, Pipedrive, SharePoint, Trello, Webflow
  • Search defaults to true in the selector framework — these overrides were unnecessary and made pickers hard to use when there are many options

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Apr 23, 2026 3:35am

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 23, 2026

PR Summary

Low Risk
Low risk UI/config change: it only removes explicit selectorAllowSearch: false flags so selectors fall back to the framework default (search enabled). Potential impact is limited to picker UX/behavior across the affected integrations.

Overview
Enables search in picker/selector subBlocks across multiple integration blocks by removing the redundant selectorAllowSearch: false overrides, letting the selector framework’s default behavior apply.

This improves usability for integrations with large numbers of selectable resources (e.g., bases, workspaces, datasets, calendars, lists, boards) without changing tool execution logic.

Reviewed by Cursor Bugbot for commit fd7932f. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 23, 2026

Greptile Summary

This PR removes explicit selectorAllowSearch: false overrides from 31 selector subBlocks across 18 integration block files. Since the selector framework defaults selectorAllowSearch to true (via ?? true in both resolution.ts and use-selector-setup.ts), these overrides were actively suppressing search functionality that would otherwise be available by default.

Confidence Score: 5/5

Safe to merge — purely subtractive change that restores intended default behavior.

All 31 removals are consistent with the framework default (selectorAllowSearch ?? true). No logic is introduced, no new risk is added, and the change aligns with the documented default.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/blocks/blocks/airtable.ts Removed selectorAllowSearch: false from baseSelector and tableSelector subBlocks — restores default search behavior.
apps/sim/blocks/blocks/asana.ts Removed selectorAllowSearch: false from two workspace selector subBlocks — restores default search behavior.
apps/sim/blocks/blocks/attio.ts Removed selectorAllowSearch: false from objectType and list selector subBlocks — restores default search behavior.
apps/sim/blocks/blocks/calcom.ts Removed selectorAllowSearch: false from four selector subBlocks (two eventType, two schedule) — restores default search behavior.
apps/sim/blocks/blocks/confluence.ts Removed selectorAllowSearch: false from spaceId selector — restores default search behavior.
apps/sim/blocks/blocks/google_bigquery.ts Removed selectorAllowSearch: false from dataset and table selectors — restores default search behavior.
apps/sim/blocks/blocks/google_calendar.ts Removed selectorAllowSearch: false from two calendar selector subBlocks — restores default search behavior.
apps/sim/blocks/blocks/google_sheets.ts Removed selectorAllowSearch: false from sheetName selector — restores default search behavior.
apps/sim/blocks/blocks/microsoft_teams.ts Removed selectorAllowSearch: false from three selectors (team, chat, channel) — restores default search behavior.
apps/sim/blocks/blocks/notion.ts Removed selectorAllowSearch: false from databaseId selector — restores default search behavior.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[SubBlock Config] --> B{selectorAllowSearch set?}
    B -- "was: false (explicit override)" --> C[Search DISABLED]
    B -- "now: undefined (removed)" --> D{Framework default}
    D -- "?? true" --> E[Search ENABLED]
    style C fill:#f88,stroke:#c00
    style E fill:#8f8,stroke:#0a0
Loading

Reviews (1): Last reviewed commit: "fix(selectors): enable search on all pic..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 merged commit bed5e95 into staging Apr 23, 2026
14 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/pickers branch April 23, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant