fix(selectors): enable search on all picker and selector subBlocks#4269
fix(selectors): enable search on all picker and selector subBlocks#4269waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview This improves usability for integrations with large numbers of selectable resources (e.g., bases, workspaces, datasets, calendars, lists, boards) without changing tool execution logic. Reviewed by Cursor Bugbot for commit fd7932f. Configure here. |
Greptile SummaryThis PR removes explicit Confidence Score: 5/5Safe to merge — purely subtractive change that restores intended default behavior. All 31 removals are consistent with the framework default (selectorAllowSearch ?? true). No logic is introduced, no new risk is added, and the change aligns with the documented default. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[SubBlock Config] --> B{selectorAllowSearch set?}
B -- "was: false (explicit override)" --> C[Search DISABLED]
B -- "now: undefined (removed)" --> D{Framework default}
D -- "?? true" --> E[Search ENABLED]
style C fill:#f88,stroke:#c00
style E fill:#8f8,stroke:#0a0
Reviews (1): Last reviewed commit: "fix(selectors): enable search on all pic..." | Re-trigger Greptile |
Summary
selectorAllowSearch: falsefrom 31 selector subBlocks across 18 integration blockstruein the selector framework — these overrides were unnecessary and made pickers hard to use when there are many optionsType of Change
Testing
Tested manually
Checklist