Error-while-phrasing-decrement-method#263
Open
ajaymrbijak wants to merge 2 commits intosequelize:mainfrom
Open
Error-while-phrasing-decrement-method#263ajaymrbijak wants to merge 2 commits intosequelize:mainfrom
ajaymrbijak wants to merge 2 commits intosequelize:mainfrom
Conversation
increment is changed to decrement in line number 714
fzn0x
approved these changes
Sep 18, 2022
Member
|
Nice catch |
WikiRik
requested changes
Sep 18, 2022
Member
WikiRik
left a comment
WikiRik
left a comment
There was a problem hiding this comment.
I believe the current wording is correct. However, it might be useful to add
await User.decrement({age: 5}, { where: { id: 1 } }) // Will decrease age to 5and update line 708 to mention both increment and decrement
Can you also update this in for the v7 docs? https://github.com/sequelize/website/blob/main/docs/core-concepts/model-querying-basics.md
sequelize-bot
Bot
added
the
conflicted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
increment is changed to decrement in line number 714