fix: integrate Explain and fix button into ErrorPage CTA area#9302
Merged
fix: integrate Explain and fix button into ErrorPage CTA area#9302
Explain and fix button into ErrorPage CTA area#9302Conversation
ericokuma
force-pushed
the
eokuma/fix-error-page-duplicate-banner
branch
from
2c83f18 to
3375f73
Compare
The `ExplainAndFixErrorButton` was rendered below the `ErrorPage` component in a separate flex container, making it look like a floating, orphaned element on 404 pages. Add a `cta` slot to `ErrorPage` and render the button inside it so it visually belongs to the error page. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ericokuma
changed the title
Explain and fix button on dashboard preview error pagesExplain and fix button into ErrorPage CTA area
Contributor
|
fixed web code qual but it looks liek this, not sure if thats what you're looking for 
|
AdityaHegde
approved these changes
Apr 27, 2026
Promote "Explain and fix" to the primary action and demote "Back to home" to a ghost button. The AI recovery action is now the more prominent option since it directly addresses the error, while the navigation escape is visually de-emphasized. - `ExplainAndFixErrorButton` gains a `variant` prop (`"compact"` default, `"cta"` for page-level use). The `cta` variant renders via Rill's `Button` component with `type="primary"` for design-system consistency - `ErrorPage` swaps `CtaButton variant="secondary"` (purple-bordered) for `Button type="ghost"` (no border, neutral text) on "Back to home" - Slot order in `ErrorPage` flipped so the `cta` slot renders above "Back to home" Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…banner
- Switch the page-context `Explain and fix` button from `primary` (filled) to `secondary` (purple outline). The button is an offer of help, not the page's main action — secondary reads as helpful without competing with the error message itself
- AND the `showError` prop with the existing `remoteContent` check in `WorkspaceEditorContainer` so callers can opt out even when the file has content
- Pass `showError={selectedView === "code"}` from `CanvasWorkspace` and `ExploreWorkspace` so the bottom red banner is suppressed when the viz pane already shows a full error page (no more duplicate `Explain and fix` buttons on the same screen)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Canvas widgets render generic placeholders (e.g. "Metrics view not found") when their dependencies are missing. Without the bottom error banner, the user can't see the underlying root cause. Show the banner whenever the canvas itself renders (`ready`), and continue to suppress it only when the full-page `ErrorPage` is shown (broken canvas spec) so we never duplicate the same message. Explore is unchanged: its viz error already shows the full root-cause text on the 404 page, so the banner stays suppressed there. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
AdityaHegde
approved these changes
Apr 27, 2026
ericokuma
added a commit
that referenced
this pull request
Apr 27, 2026
) * fix: integrate `Explain and fix` button into `ErrorPage` CTA area The `ExplainAndFixErrorButton` was rendered below the `ErrorPage` component in a separate flex container, making it look like a floating, orphaned element on 404 pages. Add a `cta` slot to `ErrorPage` and render the button inside it so it visually belongs to the error page. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Update CanvasLoadingState.svelte * fix: rework error page CTAs to use Rill `Button` component Promote "Explain and fix" to the primary action and demote "Back to home" to a ghost button. The AI recovery action is now the more prominent option since it directly addresses the error, while the navigation escape is visually de-emphasized. - `ExplainAndFixErrorButton` gains a `variant` prop (`"compact"` default, `"cta"` for page-level use). The `cta` variant renders via Rill's `Button` component with `type="primary"` for design-system consistency - `ErrorPage` swaps `CtaButton variant="secondary"` (purple-bordered) for `Button type="ghost"` (no border, neutral text) on "Back to home" - Slot order in `ErrorPage` flipped so the `cta` slot renders above "Back to home" Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix: tone down `Explain and fix` to secondary and suppress duplicate banner - Switch the page-context `Explain and fix` button from `primary` (filled) to `secondary` (purple outline). The button is an offer of help, not the page's main action — secondary reads as helpful without competing with the error message itself - AND the `showError` prop with the existing `remoteContent` check in `WorkspaceEditorContainer` so callers can opt out even when the file has content - Pass `showError={selectedView === "code"}` from `CanvasWorkspace` and `ExploreWorkspace` so the bottom red banner is suppressed when the viz pane already shows a full error page (no more duplicate `Explain and fix` buttons on the same screen) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix: keep banner visible in canvas viz when widgets show shallow errors Canvas widgets render generic placeholders (e.g. "Metrics view not found") when their dependencies are missing. Without the bottom error banner, the user can't see the underlying root cause. Show the banner whenever the canvas itself renders (`ready`), and continue to suppress it only when the full-page `ErrorPage` is shown (broken canvas spec) so we never duplicate the same message. Explore is unchanged: its viz error already shows the full root-cause text on the 404 page, so the banner stays suppressed there. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: royendo <67675319+royendo@users.noreply.github.com> (cherry picked from commit bb2945c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ExplainAndFixErrorButtonwas rendered below theErrorPagecomponent in a separate flex container on dashboard preview 404s (canvas and explore), making it look like a floating, orphaned element. Add actaslot toErrorPageand render the button inside it so it visually belongs to the error page.Follow-up to #9221. Intended to be cherry-picked into
release-0.86.Checklist:
Developed in collaboration with Claude Code