Skip to content

feat: add --include-installer-images flag to release image ls#702

Open
banjoh wants to merge 2 commits intomainfrom
evansmungai/sc-136471/byo-registry-design
Open

feat: add --include-installer-images flag to release image ls#702
banjoh wants to merge 2 commits intomainfrom
evansmungai/sc-136471/byo-registry-design

Conversation

@banjoh
Copy link
Copy Markdown
Member

@banjoh banjoh commented Apr 24, 2026

Description

Add --include-installer-images flag to release image ls command, enabling
customers to list EC infrastructure images alongside app images for BYO registry
workflows.

Motivation and Context

When using a BYO registry with EC, customers need to know which images to push to
their registry. The existing release image ls only shows app images. With
--include-installer-images, customers can get the complete list including EC
infrastructure images (k0s, openebs, rook, etc.).

How Has This Been Tested?

  • go build ./... passes
  • Manual verification of flag threading and validation

Summary of Changes

  • Add --include-installer-images flag to release image ls (valid values:
    online, airgap)
  • Thread includeInstallerImages query parameter through GetChannel,
    GetCurrentChannelRelease, ListChannelReleases, GetKotsChannel
  • Add input validation rejecting values other than "online" or "airgap"
  • Add help examples demonstrating the new flag
  • Existing callers pass "" (no behavior change for current users)

banjoh and others added 2 commits April 23, 2026 17:59
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Previously GetCurrentChannelRelease only passed includeInstallerImages
through the ListChannelReleases fallback. Now the parameter is threaded
through GetChannel/GetKotsChannel so the direct channel extraction path
also includes installer images when requested.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fda8a7f. Configure here.

Comment thread cli/cmd/release_image_ls.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant