feat(placements): add placements content configuration API by DanielSinclair · Pull Request #7416 · rainbow-me/rainbow

DanielSinclair · 2026-04-30T08:42:51Z

APP-3530, APP-3660

What changed

Introduces a generic placements API for remotely configuring featured content slots across the app. Built generically so future screens beyond Discover can add their own placement types without schema changes — screen-specific derived stores live under src/features/placements/stores/<screen>/.

Schema — each document in the Firestore placements collection (rainbow-me → (default) DB):

placements/{id}
  enabled: boolean
  screen:  "discover"
  order:   number
  items: [{ ref: { source: "hyperliquid" | "polymarket", id: string }, order: number }]

usePlacementsStore — fetches enabled placement documents from Firestore, items sorted by order
useDiscoverPlacementAvailabilityStore — derived store computing which Discover placement types are active; produces { perps: boolean, predictions: boolean, enabled: boolean } consumed by all downstream Discover stores
discover_placements_enabled remote config gates the feature (defaults true)
Local experimental flags (via useExperimentalConfigStore) and testnet state also gate individual placement types
New dependencies: @react-native-firebase/firestore (npm), Firebase/Firestore pod — run pod install in ios/ after pulling

Screen recordings / screenshots

What to test

With Firestore placements collection populated: usePlacementsStore.getState().getPlacement('discover-perps') returns the document with items sorted by order

socket-security · 2026-04-30T08:44:12Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/@react-native-firebase/firestore@23.8.8

View full report

Native dep commit so the rebuild requirement is clearly attributed.

Fetch enabled Firestore placement documents, sort items by order, persist with 1h stale / 2d cache.

Named constants prevent string drift between Firestore documents and client code.

Derives which Discover placement types are enabled from remote config, experimental flags, and testnet state. Sets discover_placements_enabled remote config default to true.

DanielSinclair · 2026-04-30T08:51:18Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4eb79840e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-30T08:53:56Z

+  testnet: false,
+  setTestnet: testnet => set({ testnet }),


Initialize testnet state before deriving availability

This store starts with testnet: false and only updates it in useEffect, so on a real testnet account the first render computes availability as if the user were on mainnet. Any consumer that reads useDiscoverPlacementAvailability during that initial render can briefly enable placements (and trigger dependent fetch/render work) before the effect flips the value, which is a user-visible and behaviorally incorrect transient state.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-30T08:53:56Z

+      .map((d: { id: string; data: () => Record<string, unknown> }) => ({ id: d.id, ...d.data() }) as Placement)
+      .map((p: Placement) => ({
+        ...p,
+        items: (p.items ?? []).sort((a: PlacementItem, b: PlacementItem) => a.order - b.order),


Validate placement items before calling sort

The code assumes p.items is always an array and directly calls .sort after only nullish fallback. Because Firestore documents are schemaless, a malformed items value (e.g. object/string from bad config) will throw TypeError here, causing the whole placements fetch to fail instead of safely skipping/normalizing that document.

Useful? React with 👍 / 👎.

github-actions · 2026-04-30T11:56:04Z

Launch in simulator or device for 98b6605

github-actions · 2026-04-30T12:06:36Z

🧪 Flashlight Performance Report (AWS Device Farm)

🔀 Commit: 98b6605

📎 View Artifacts

Metric	Current	Δ vs Baseline
Time to Interactive (TTI)	5624 ms	–
Average FPS	56.48	–
Average RAM	399.7 MB	–

maxbbb · 2026-05-01T14:02:54Z

+        items: (p.items ?? []).sort((a: PlacementItem, b: PlacementItem) => a.order - b.order),
+      }));
+  } catch (e) {
+    logger.error(new RainbowError('[placementsStore]: Failed to fetch placements', e as Error), { error: e });


The second argument (e as Error) doesn't require type casting. Also we should not pass the error object along in the metadata param anymore, it's regularly dropped by Sentry due to its size and is more properly used as the cause (which is the second argument of RainbowError).

All that being said, the query stores handle wrapping these fetches in try catch and logging the errors, so don't think we need this here at all.

maxbbb · 2026-05-01T14:05:35Z

+    getPlacement: (id: string) => get().placements.find(p => p.id === id),
+  }),
+  {
+    partialize: state => ({ placements: state.placements }),


Should only define this partialize when there is some portion of the state we're omitting. I believe currently this has the same behavior as not defining it.

maxbbb · 2026-05-01T15:10:45Z

+export const PLACEMENT_IDS = {
+  PERPS: 'discover_featured_perps_carousel',
+  PREDICTIONS: 'discover_featured_predictions_carousel',
+} as const;


If we had some other placement of perps on another screen / location what would it's key in this object be? I would assume "perps" and "predictions" are too generic to handle additions cleanly, and the keys would be the aligned with the values in this case.

maxbbb · 2026-05-01T16:28:14Z

+const useDiscoverPlacementNetworkStore = createRainbowStore<DiscoverPlacementNetworkState>(set => ({
+  testnet: false,
+  setTestnet: testnet => set({ testnet }),
+}));


I understand that supporting the isTestnet logic is maintaining how the perps and predictions cards were previously rendered, but given the extra complexity it adds here I think it's worth interrogating whether it's required at all.

Taking a quick trace through I'm not sure there is any functional reason these need to not be displayed when isTestnet is true.

maxbbb · 2026-05-01T16:37:16Z

+    const polymarketLocal = $(
+      useExperimentalConfigStore,
+      state => IS_INTERNAL && (state.config[POLYMARKET] ?? defaultConfig[POLYMARKET].value)


Would be nice if the store exported a helper like getExperimentalFlagValue that did this IS_INTERNAL and default fallback given it will always be required when accessing a value outside of the useExperimentalFlag hook. That hook could use the same helper so that the logic only has one source of truth.

maxbbb · 2026-05-01T16:45:33Z

+  return testnet;
+}
+
+export function computeDiscoverPlacementAvailability({


Unless this is used somewhere else in a later PR, shouldn't be exported. Also it's adding misdirection being a separate function vs. just inlined above.

maxbbb · 2026-05-01T17:01:47Z

+    return snap.docs
+      .map((d: { id: string; data: () => Record<string, unknown> }) => ({ id: d.id, ...d.data() }) as Placement)
+      .map((p: Placement) => ({
+        ...p,
+        items: (p.items ?? []).sort((a: PlacementItem, b: PlacementItem) => a.order - b.order),
+      }));


This could be a little cleaner with a helper like this:

function parsePlacementDoc(doc: QueryDocumentSnapshot): Placement { const data = doc.data() as Omit<Placement, 'id'>; return { ...data, id: doc.id, items: [...(data.items ?? [])].sort((a, b) => a.order - b.order), }; }

Which makes it more clear what it's doing to each doc and lets us only iterate through the docs once.

maxbbb · 2026-05-01T17:07:23Z

+const PLACEMENTS_STALE_TIME = time.hours(1);
+const PLACEMENTS_CACHE_TIME = time.days(2);


nit: these would be fine inlined below

maxbbb · 2026-05-01T17:09:57Z

+  },
+  (_set, get) => ({
+    placements: [],
+    getPlacement: (id: string) => get().placements.find(p => p.id === id),


Obviously not consequential given the number of these, but given we'll always be getting these by id, I wonder if it would be better for the main data structure returned by the fetch function to be placementsById rather than an array, so that lookup doesn't require looping the whole thing every time.

maxbbb · 2026-05-01T17:18:47Z

+  id: string;
+  screen: string;


We could type these more concretely ie. (typeof PLACEMENT_IDS)[keyof typeof PLACEMENT_IDS];

DanielSinclair requested a review from akc2267 April 30, 2026 08:43

DanielSinclair added 4 commits April 30, 2026 04:50

chore(firebase): add Firestore support

ea7bca6

Native dep commit so the rebuild requirement is clearly attributed.

feat(placements): add placements data layer

2989674

Fetch enabled Firestore placement documents, sort items by order, persist with 1h stale / 2d cache.

feat(placements): define Discover placement IDs

e67a0cc

Named constants prevent string drift between Firestore documents and client code.

feat(discover-v2): add placement availability store

3d587fb

Derives which Discover placement types are enabled from remote config, experimental flags, and testnet state. Sets discover_placements_enabled remote config default to true.

DanielSinclair force-pushed the daniel/placements-api branch from 4eb7984 to 3d587fb Compare April 30, 2026 08:51

DanielSinclair mentioned this pull request Apr 30, 2026

chore(discover): hide Farcaster tab from Trending #7414

Merged

chatgpt-codex-connector Bot reviewed Apr 30, 2026

View reviewed changes

ci: trigger fresh CI run

020b76a

DanielSinclair requested review from maxbbb and removed request for akc2267 April 30, 2026 23:23

maxbbb requested changes May 1, 2026

View reviewed changes

		const PLACEMENTS_STALE_TIME = time.hours(1);
		const PLACEMENTS_CACHE_TIME = time.days(2);

Conversation

DanielSinclair commented Apr 30, 2026

What changed

Screen recordings / screenshots

What to test

Uh oh!

socket-security Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielSinclair commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

socket-security Bot commented Apr 30, 2026 •

edited

Loading

DanielSinclair commented Apr 30, 2026 •

edited

Loading