chore: remove @shopify/react-native-performance#7398
Draft
janicduplessis wants to merge 1 commit intodevelopfrom
Draft
chore: remove @shopify/react-native-performance#7398janicduplessis wants to merge 1 commit intodevelopfrom
janicduplessis wants to merge 1 commit intodevelopfrom
Conversation
… tracker Two layers of unused infra coming out together: 1. @shopify/react-native-performance — unmaintained since Aug 2022, upstream main still has the Map<String, Any> override variance bug that breaks Android Kotlin compile on RN 0.81+. Drops the lib, the patch, the <PerformanceProfiler>/<PerformanceMeasureView> wraps, ReactNativePerformance.onAppStarted() in MainApplication.kt, and the iOS native module wiring. 2. The in-house PerformanceTracking module (src/performance/) — emitted the analytics events 'performance.report' and 'Performance Wallet Initialize Time' to Rudderstack on prod/staging builds. No dashboards or alerts consume them, so the events were write-only. Removes the entire src/performance/ tree, all call sites (App.tsx, index.js, useApplicationSetup, useHideSplashScreen, wallet-connect listeners, initializeWallet), the now-unused onReady prop on Routes, and the two event definitions in analytics/event.ts. Net: 649 lines deleted, 10 added. No replacement signal — if we want startup-perf metrics later, Sentry's tracing already covers TTI.
janicduplessis
force-pushed
the
@janic/remove-shopify-perf
branch
from
49bc467 to
1a63dad
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
Removes two layers of unused performance infra as RN 0.81 prep:
@shopify/react-native-performance— unmaintained since Aug 2022, upstream still has theMap<String, Any>override variance bug that breaks Android Kotlin compile on RN 0.81+. Lets us droppatches/@shopify+react-native-performance+4.1.2.patch.PerformanceTrackingmodule (src/performance/) — emittedperformance.reportandPerformance Wallet Initialize Timeto Rudderstack → Amplitude on every prod/staging start. Nothing in Rainbow consumes them — write-only.Pulled together because the in-house module wraps the same call sites the lib touched. If we want startup metrics back later, Sentry tracing covers TTI and we already ship
@sentry/react-native.src/state/performance/performance.tsis an unrelated Zustand store with a similar name — untouched.Screen recordings / screenshots
N/A — no visual changes.
What to test
yarn android) — load-bearing test, both removals collide here.bundle exec pod installdropsreact-native-performance,yarn iossucceeds.performance.reportandPerformance Wallet Initialize Timestop arriving in Amplitude from this build.