Skip to content

Partially support old NumPy plugin in parallel type checking #21324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 2 commits into from
Apr 25, 2026
+8 −0
Merged

Partially support old NumPy plugin in parallel type checking #21324

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52f1547
Try un-breaking old NumPy plugin
ilevkivskyi Apr 24, 2026
d3c98ca
Add a comment
ilevkivskyi Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions mypy/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3358,9 +3358,17 @@ def compute_dependencies(self) -> None:
self.priorities = {} # id -> priority
self.dep_line_map = {} # id -> line
self.dep_hashes = {}
# We copy imports as defs to (partially) support some legacy mypy plugins,
# most notably old NumPy plugin that does some imports patching, see #21323.
copied_imports = False
if not self.tree.defs and self.tree.raw_data is not None:
self.tree.defs = list(self.tree.imports)
copied_imports = True
dep_entries = manager.all_imported_modules_in_file(
self.tree
) + self.manager.plugin.get_additional_deps(self.tree)
if copied_imports:
self.tree.defs = []
for pri, id, line in dep_entries:
self.priorities[id] = min(pri, self.priorities.get(id, PRI_ALL))
if id == self.id:
Expand Down
Loading