Skip to content

Add the jira plugin for edge-tooling#78325

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
brandisher:patch-1
Apr 24, 2026
Merged

Add the jira plugin for edge-tooling#78325
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
brandisher:patch-1

Conversation

@brandisher
Copy link
Copy Markdown
Contributor

@brandisher brandisher commented Apr 24, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Enabled JIRA integration for project configuration, allowing enhanced issue tracking and project management capabilities across repositories.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

Walkthrough

Adds the jira plugin to the Prow plugin configuration for the openshift-eng/edge-tooling repository. This is a single-line configuration modification with no changes to other plugin settings, triggers, or approval mechanisms.

Changes

Cohort / File(s) Summary
Prow Plugin Configuration
core-services/prow/02_config/openshift-eng/edge-tooling/_pluginconfig.yaml
Adds jira plugin to the enabled plugins list for the edge-tooling repository.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add the jira plugin for edge-tooling' directly and accurately describes the main change in the pull request, which adds the jira plugin to the Prow configuration for the openshift-eng/edge-tooling repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The custom check for stable and deterministic Ginkgo test names is not applicable to this PR, which only modifies a YAML configuration file for Prow plugins without including any test files or test titles.
Test Structure And Quality ✅ Passed This PR modifies only a Prow plugin configuration YAML file, not test code. The custom Ginkgo test quality check is not applicable.
Microshift Test Compatibility ✅ Passed This PR modifies a Prow plugin configuration file, not Ginkgo e2e tests, so the MicroShift compatibility check is inapplicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only a Prow plugin configuration file without adding any Ginkgo e2e tests, making the SNO test compatibility check inapplicable.
Topology-Aware Scheduling Compatibility ✅ Passed Pull request modifies Prow plugin configuration file to enable jira plugin; does not introduce scheduling constraints or topology-aware considerations.
Ote Binary Stdout Contract ✅ Passed The PR modifies a YAML configuration file adding the jira plugin to Prow, which is declarative configuration with no executable code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This pull request modifies a Prow plugin configuration file, not Ginkgo e2e tests, so the IPv6/network compatibility check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2026
@openshift-ci openshift-ci Bot requested review from fracappa and vimauro April 24, 2026 12:24
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
core-services/prow/02_config/openshift-eng/edge-tooling/_pluginconfig.yaml (1)

19-19: Confirm whether jira-lifecycle-plugin external plugin is also needed.

Enabling the built-in jira plugin on its own is valid (it handles Jira issue references in PR titles/commits). However, the common OpenShift pattern — e.g. core-services/prow/02_config/kubev2v/migration-planner/_pluginconfig.yaml — pairs it with an external_plugins entry for jira-lifecycle-plugin (events: issue_comment, pull_request) to drive Jira issue lifecycle transitions from PRs. This file has no external_plugins section. Please confirm this is intentional and that the team only wants the built-in plugin's behavior, not full lifecycle automation.

♻️ Optional pattern if lifecycle automation is desired
+external_plugins:
+  openshift-eng/edge-tooling:
+  - endpoint: http://jira-lifecycle-plugin
+    events:
+    - issue_comment
+    - pull_request
+    name: jira-lifecycle-plugin
 approve:
 - repos:
   - openshift-eng/edge-tooling
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@core-services/prow/02_config/openshift-eng/edge-tooling/_pluginconfig.yaml`
at line 19, The pluginconfig enables the built-in jira plugin but omits the
external jira-lifecycle-plugin used in other OpenShift configs; confirm desired
behavior and if lifecycle automation is required, add an external_plugins entry
for jira-lifecycle-plugin with the events issue_comment and pull_request to
match the pattern used in kubev2v/migration-planner; alternatively, if only
reference parsing is wanted, explicitly document that only the built-in jira
plugin is intentionally enabled and no external_plugins section should be added.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@core-services/prow/02_config/openshift-eng/edge-tooling/_pluginconfig.yaml`:
- Line 19: The pluginconfig enables the built-in jira plugin but omits the
external jira-lifecycle-plugin used in other OpenShift configs; confirm desired
behavior and if lifecycle automation is required, add an external_plugins entry
for jira-lifecycle-plugin with the events issue_comment and pull_request to
match the pattern used in kubev2v/migration-planner; alternatively, if only
reference parsing is wanted, explicitly document that only the built-in jira
plugin is intentionally enabled and no external_plugins section should be added.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d6555567-97bd-4288-a155-f41a593e12c3

📥 Commits

Reviewing files that changed from the base of the PR and between 045c823 and 29440f0.

📒 Files selected for processing (1)
  • core-services/prow/02_config/openshift-eng/edge-tooling/_pluginconfig.yaml

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@brandisher: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 24, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brandisher, vimauro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@brandisher: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit f5e06cb into openshift:main Apr 24, 2026
12 checks passed
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@brandisher: Updated the plugins configmap in namespace ci at cluster app.ci using the following files:

  • key core-services-prow-02_config-openshift-eng-edge-tooling-_pluginconfig.yaml using file core-services/prow/02_config/openshift-eng/edge-tooling/_pluginconfig.yaml
Details

In response to this:

Summary by CodeRabbit

Release Notes

  • Chores
  • Enabled JIRA integration for project configuration, allowing enhanced issue tracking and project management capabilities across repositories.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants