Add the jira plugin for edge-tooling#78325
Add the jira plugin for edge-tooling#78325openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
WalkthroughAdds the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
core-services/prow/02_config/openshift-eng/edge-tooling/_pluginconfig.yaml (1)
19-19: Confirm whetherjira-lifecycle-pluginexternal plugin is also needed.Enabling the built-in
jiraplugin on its own is valid (it handles Jira issue references in PR titles/commits). However, the common OpenShift pattern — e.g.core-services/prow/02_config/kubev2v/migration-planner/_pluginconfig.yaml— pairs it with anexternal_pluginsentry forjira-lifecycle-plugin(events:issue_comment,pull_request) to drive Jira issue lifecycle transitions from PRs. This file has noexternal_pluginssection. Please confirm this is intentional and that the team only wants the built-in plugin's behavior, not full lifecycle automation.♻️ Optional pattern if lifecycle automation is desired
+external_plugins: + openshift-eng/edge-tooling: + - endpoint: http://jira-lifecycle-plugin + events: + - issue_comment + - pull_request + name: jira-lifecycle-plugin approve: - repos: - openshift-eng/edge-tooling🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@core-services/prow/02_config/openshift-eng/edge-tooling/_pluginconfig.yaml` at line 19, The pluginconfig enables the built-in jira plugin but omits the external jira-lifecycle-plugin used in other OpenShift configs; confirm desired behavior and if lifecycle automation is required, add an external_plugins entry for jira-lifecycle-plugin with the events issue_comment and pull_request to match the pattern used in kubev2v/migration-planner; alternatively, if only reference parsing is wanted, explicitly document that only the built-in jira plugin is intentionally enabled and no external_plugins section should be added.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@core-services/prow/02_config/openshift-eng/edge-tooling/_pluginconfig.yaml`:
- Line 19: The pluginconfig enables the built-in jira plugin but omits the
external jira-lifecycle-plugin used in other OpenShift configs; confirm desired
behavior and if lifecycle automation is required, add an external_plugins entry
for jira-lifecycle-plugin with the events issue_comment and pull_request to
match the pattern used in kubev2v/migration-planner; alternatively, if only
reference parsing is wanted, explicitly document that only the built-in jira
plugin is intentionally enabled and no external_plugins section should be added.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: d6555567-97bd-4288-a155-f41a593e12c3
📒 Files selected for processing (1)
core-services/prow/02_config/openshift-eng/edge-tooling/_pluginconfig.yaml
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brandisher, vimauro The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@brandisher: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@brandisher: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary by CodeRabbit
Release Notes