Skip to content

Mirror the pause image to additional locations#78321

Open
mgencur wants to merge 2 commits intoopenshift:mainfrom
mgencur:main
Open

Mirror the pause image to additional locations#78321
mgencur wants to merge 2 commits intoopenshift:mainfrom
mgencur:main

Conversation

@mgencur
Copy link
Copy Markdown
Contributor

@mgencur mgencur commented Apr 24, 2026

Fixes the issue from #78238 (comment)

The image index is now different:
https://github.com/openshift/origin/blob/main/vendor/k8s.io/kubernetes/test/utils/image/manifest.go
Some time ago, some images were removed from the list so the resulting
index is 22, not 25. We now mirror the image to both 22 and 25 to preserve backwards
compatibility.

This is a temporary solution. It needs some re-work to prevent the issue in the future as it already happens 3 times:
e.g. e4b3139

Summary by CodeRabbit

  • Tests

    • Enhanced conformance testing setup with support for additional container images in the mirroring pipeline.
  • Chores

    • Optimized test cleanup workflows by streamlining post-execution step sequences across multiple conformance test configurations.

mgencur added 2 commits April 24, 2026 13:32
…__nK-VRxiifU0Z

The image index is now different:
https://github.com/openshift/origin/blob/main/vendor/k8s.io/kubernetes/test/utils/image/manifest.go
Some time ago, some images were removed from the list so the resulting
index is 22, not 25.
We now mirror the image to both 22 and 25 to preserve backwards
compatibility.
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgencur
Once this PR has been reviewed and has the lgtm label, please assign csrwng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur
Copy link
Copy Markdown
Contributor Author

mgencur commented Apr 24, 2026

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0e9dc18b-e75a-4450-a405-f081324b4dc7

📥 Commits

Reviewing files that changed from the base of the PR and between c68a0c3 and 64bfb2b.

📒 Files selected for processing (3)
  • ci-operator/step-registry/hypershift/conformance/hypershift-conformance-chain.yaml
  • ci-operator/step-registry/hypershift/mce/agent/manual/conformance/hypershift-mce-agent-manual-conformance-workflow.yaml
  • ci-operator/step-registry/hypershift/mce/kubevirt/baremetalds/conformance/hypershift-mce-kubevirt-baremetalds-conformance-workflow.yaml
💤 Files with no reviewable changes (2)
  • ci-operator/step-registry/hypershift/mce/agent/manual/conformance/hypershift-mce-agent-manual-conformance-workflow.yaml
  • ci-operator/step-registry/hypershift/mce/kubevirt/baremetalds/conformance/hypershift-mce-kubevirt-baremetalds-conformance-workflow.yaml

Walkthrough

Three CI/CD workflow configuration files are modified: one adds an image-mirroring step for pause image handling in Hypershift conformance setup, while two remove wait step references from MCE workflow post-test cleanup sequences.

Changes

Cohort / File(s) Summary
Conformance Image Mirroring
ci-operator/step-registry/hypershift/conformance/hypershift-conformance-chain.yaml
Adds image-mirroring step to mirror pause:3.10.1 source image into local test images repository under new e2e-22-... destination tag.
Workflow Post-Step Cleanup
ci-operator/step-registry/hypershift/mce/agent/manual/conformance/hypershift-mce-agent-manual-conformance-workflow.yaml, ci-operator/step-registry/hypershift/mce/kubevirt/baremetalds/conformance/hypershift-mce-kubevirt-baremetalds-conformance-workflow.yaml
Removes wait step references from post-test cleanup sequences in MCE-related workflow definitions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Mirror the pause image to additional locations' accurately reflects the main change in the PR, which adds mirroring of the pause:3.10.1 image to an additional registry location (e2e-22-...) while maintaining backward compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only YAML CI/CD workflow configuration files, not Go test code containing Ginkgo test definitions.
Test Structure And Quality ✅ Passed PR modifies only CI/CD workflow YAML configuration files, not Ginkgo test code, so test quality checks are not applicable.
Microshift Test Compatibility ✅ Passed This pull request does not add any new Ginkgo e2e tests. The changes consist solely of modifications to CI/CD configuration files in the ci-operator/step-registry/ directory, specifically YAML workflow definitions.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The custom check for Single Node OpenShift test compatibility is not applicable. This PR modifies only YAML CI configuration files, not Ginkgo e2e test code.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI/CD workflow configuration files without deployment manifests, operator code, or Kubernetes workload controllers with scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The pull request modifies only YAML configuration files for OpenShift CI workflows, not OTE binary source code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies CI-operator workflow configurations and image mirroring settings only; no new Ginkgo e2e tests are added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mgencur: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-api-master-e2e-aws-ovn-hypershift-conformance openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-5.1-e2e-aws-ovn-hypershift-conformance openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-5.0-e2e-aws-ovn-hypershift-conformance openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.23-e2e-aws-ovn-hypershift-conformance openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.22-e2e-aws-ovn-hypershift-conformance openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.21-e2e-aws-ovn-hypershift-conformance openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.20-e2e-aws-ovn-hypershift-conformance openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.19-e2e-aws-ovn-hypershift-conformance openshift/api presubmit Registry content changed
pull-ci-openshift-cluster-monitoring-operator-main-e2e-hypershift-conformance openshift/cluster-monitoring-operator presubmit Registry content changed
pull-ci-openshift-cluster-monitoring-operator-release-5.1-e2e-hypershift-conformance openshift/cluster-monitoring-operator presubmit Registry content changed
pull-ci-openshift-cluster-monitoring-operator-release-5.0-e2e-hypershift-conformance openshift/cluster-monitoring-operator presubmit Registry content changed
pull-ci-openshift-cluster-monitoring-operator-release-4.23-e2e-hypershift-conformance openshift/cluster-monitoring-operator presubmit Registry content changed
pull-ci-openshift-cluster-monitoring-operator-release-4.22-e2e-hypershift-conformance openshift/cluster-monitoring-operator presubmit Registry content changed
pull-ci-openshift-cluster-monitoring-operator-release-4.21-e2e-hypershift-conformance openshift/cluster-monitoring-operator presubmit Registry content changed
pull-ci-openshift-cluster-monitoring-operator-release-4.20-e2e-hypershift-conformance openshift/cluster-monitoring-operator presubmit Registry content changed
pull-ci-openshift-cluster-monitoring-operator-release-4.19-e2e-hypershift-conformance openshift/cluster-monitoring-operator presubmit Registry content changed
pull-ci-openshift-cluster-monitoring-operator-release-4.18-e2e-hypershift-conformance openshift/cluster-monitoring-operator presubmit Registry content changed
pull-ci-openshift-cluster-monitoring-operator-release-4.17-e2e-hypershift-conformance openshift/cluster-monitoring-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-hypershift-conformance openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-5.1-e2e-hypershift-conformance openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-5.0-e2e-hypershift-conformance openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.23-e2e-hypershift-conformance openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.22-e2e-hypershift-conformance openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.21-e2e-hypershift-conformance openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.20-e2e-hypershift-conformance openshift/cluster-image-registry-operator presubmit Registry content changed

A total of 603 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant