NO-JIRA: feat: add MCP Gateway and smoke test steps to openshift-mcp-server e2e by matzew · Pull Request #78314 · openshift/release

matzew · 2026-04-24T09:23:41Z

Add install-gateway, register-mcp-server, and smoke-test steps to the e2e-aws test for openshift-mcp-server release-0.3. The full step flow is now: install-operator, install-gateway, deploy-mcp-server, register-mcp-server, wait-ready, smoke-test.

Summary by CodeRabbit

Chores
- Streamlined the E2E testing workflow by consolidating multiple initialization and verification steps into a single unified test step, simplifying the continuous integration pipeline.

Add install-gateway, register-mcp-server, and smoke-test steps to the e2e-aws test for openshift-mcp-server release-0.3. The full step flow is now: install-operator, install-gateway, deploy-mcp-server, register-mcp-server, wait-ready, smoke-test. Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

openshift-ci-robot · 2026-04-24T09:23:44Z

@matzew: This pull request explicitly references no jira issue.

Details

In response to this:

Add install-gateway, register-mcp-server, and smoke-test steps to the e2e-aws test for openshift-mcp-server release-0.3. The full step flow is now: install-operator, install-gateway, deploy-mcp-server, register-mcp-server, wait-ready, smoke-test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-04-24T09:24:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/openshift-mcp-server/OWNERS~~ [matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-04-24T09:24:20Z

Walkthrough

The e2e-aws workflow in the CI configuration is simplified by consolidating three separate installation and deployment steps (install-operator, deploy-mcp-server, wait-ready) into a single e2e-test step that invokes a Makefile command.

Changes

Cohort / File(s)	Summary
CI Workflow Consolidation `ci-operator/config/openshift/openshift-mcp-server/openshift-openshift-mcp-server-release-0.3.yaml`	The e2e-aws workflow steps are consolidated from three separate steps (install-operator, deploy-mcp-server, wait-ready) into one e2e-test step that runs `make -f Makefile-ocp.mk e2e-test` with MCP_SERVER_IMAGE environment variable set, while maintaining dependency references for openshift-mcp-server.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title states 'add MCP Gateway and smoke test steps' but the actual changes only show simplification from multiple steps to a single e2e-test step, with no new steps added.	Update the title to accurately reflect the changes, such as 'Simplify e2e-aws workflow by consolidating installation and deployment steps into single e2e-test step'.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only YAML CI/CD configuration files with no Ginkgo test code, making this test validation check not applicable.
Test Structure And Quality	✅ Passed	PR modifies only CI operator configuration YAML files, not Ginkgo test code. Check designed for test code review is not applicable.
Microshift Test Compatibility	✅ Passed	Pull request modifies only YAML CI pipeline configuration and adds no new Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR modifies only CI/CD pipeline configuration (YAML) without adding any new Ginkgo e2e test code (It(), Describe(), Context(), When()), so the SNO Test Compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR modifies a CI operator configuration YAML file for test orchestration, not deployment manifests or operator code. No topology-aware scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	PR modifies only YAML CI/CD configuration files without introducing executable code that could violate OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies only CI/Tekton YAML and infrastructure files with no new Ginkgo e2e test code added.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

ci-operator/config/openshift/openshift-mcp-server/openshift-openshift-mcp-server-release-0.3.yaml (1)
34-46: ⚠️ Potential issue | 🔴 Critical

Makefile-ocp.mk does not contain the e2e-test target referenced in this step — the command will fail.

The CI step at lines 34-46 executes make -f Makefile-ocp.mk e2e-test, but verification of Makefile-ocp.mk on the release-0.3 branch of openshift/openshift-mcp-server shows no e2e-test target exists. The Makefile contains only a build-ocp target. This will cause a "No rule to make target 'e2e-test'" error when the step runs.

Additionally, the PR description claims this PR adds three new steps (install-gateway, register-mcp-server, smoke-test) to create a 6-step flow, but the YAML file defines only a single consolidated e2e-test step. Either the PR description is stale, or the intended changes were not committed. Before this can merge:

Create the e2e-test target in Makefile-ocp.mk (or fix the target name if it's defined elsewhere)

Clarify the PR intent and update the description to match the actual file changes

Ensure the Makefile properly consumes the MCP_SERVER_IMAGE environment variable
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@ci-operator/config/openshift/openshift-mcp-server/openshift-openshift-mcp-server-release-0.3.yaml`
around lines 34 - 46, The CI step invokes "make -f Makefile-ocp.mk e2e-test" but
Makefile-ocp.mk on release-0.3 has no e2e-test target (only build-ocp), causing
a "No rule" failure; add an e2e-test target to Makefile-ocp.mk (or change the
YAML to call the correct existing target) that sequences the intended steps
(install-gateway, register-mcp-server, smoke-test) and consumes the
MCP_SERVER_IMAGE env var (use MCP_SERVER_IMAGE in the commands/recipes) so the
CI command succeeds; also update the PR description to reflect whether you added
the three explicit targets or consolidated them under e2e-test.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In
`@ci-operator/config/openshift/openshift-mcp-server/openshift-openshift-mcp-server-release-0.3.yaml`:
- Around line 34-46: The CI step invokes "make -f Makefile-ocp.mk e2e-test" but
Makefile-ocp.mk on release-0.3 has no e2e-test target (only build-ocp), causing
a "No rule" failure; add an e2e-test target to Makefile-ocp.mk (or change the
YAML to call the correct existing target) that sequences the intended steps
(install-gateway, register-mcp-server, smoke-test) and consumes the
MCP_SERVER_IMAGE env var (use MCP_SERVER_IMAGE in the commands/recipes) so the
CI command succeeds; also update the PR description to reflect whether you added
the three explicit targets or consolidated them under e2e-test.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7ae45c00-3622-4572-9a02-f020e477e12a

📥 Commits

Reviewing files that changed from the base of the PR and between d9e4aff and 776e525.

📒 Files selected for processing (1)

ci-operator/config/openshift/openshift-mcp-server/openshift-openshift-mcp-server-release-0.3.yaml

openshift-merge-bot · 2026-04-24T09:30:20Z

[REHEARSALNOTIFIER]
@matzew: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-openshift-mcp-server-release-0.3-e2e-aws	openshift/openshift-mcp-server	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

matzew · 2026-04-24T10:42:33Z

/retest

matzew · 2026-04-24T10:47:14Z

/pj-rehearse

openshift-merge-bot · 2026-04-24T10:47:16Z

@matzew: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

matzew · 2026-04-24T14:05:57Z

/pj-rehearse pull-ci-openshift-openshift-mcp-server-release-0.3-e2e-aws

openshift-merge-bot · 2026-04-24T14:06:00Z

@matzew: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2026-04-24T15:48:32Z

@matzew: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/openshift-mcp-server/release-0.3/e2e-aws	`776e525`	link	unknown	`/pj-rehearse pull-ci-openshift-openshift-mcp-server-release-0.3-e2e-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 24, 2026

openshift-ci Bot requested review from Cali0707 and Kaustubh-pande April 24, 2026 09:24

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2026

coderabbitai Bot reviewed Apr 24, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NO-JIRA: feat: add MCP Gateway and smoke test steps to openshift-mcp-server e2e#78314

NO-JIRA: feat: add MCP Gateway and smoke test steps to openshift-mcp-server e2e#78314
matzew wants to merge 1 commit intoopenshift:mainfrom
matzew:e2e-mcp-gateway

matzew commented Apr 24, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

openshift-ci-robot commented Apr 24, 2026

Uh oh!

openshift-ci Bot commented Apr 24, 2026

Uh oh!

coderabbitai Bot commented Apr 24, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

openshift-merge-bot Bot commented Apr 24, 2026

Uh oh!

matzew commented Apr 24, 2026

Uh oh!

matzew commented Apr 24, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 24, 2026

Uh oh!

matzew commented Apr 24, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 24, 2026

Uh oh!

openshift-ci Bot commented Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

matzew commented Apr 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Apr 24, 2026

Uh oh!

openshift-ci Bot commented Apr 24, 2026

Uh oh!

coderabbitai Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-merge-bot Bot commented Apr 24, 2026

Uh oh!

matzew commented Apr 24, 2026

Uh oh!

matzew commented Apr 24, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 24, 2026

Uh oh!

matzew commented Apr 24, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 24, 2026

Uh oh!

openshift-ci Bot commented Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

matzew commented Apr 24, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 24, 2026 •

edited

Loading