Add /test e2e-capi-sno Prow command for CAPI provider#78302
Add /test e2e-capi-sno Prow command for CAPI provider#78302openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughAdds a Single Node OpenShift (SNO) CAPI e2e test and supporting CI: new presubmit job and config entry, a SNO-specific workflow (pre/test/post), workflow metadata and OWNERS, and test-step changes exporting CLUSTER_TOPOLOGY and NUMBER_OF_NODES. Changes
Sequence Diagram(s)sequenceDiagram
participant Prow as Prow CI
participant CI as ci-operator
participant OFCIR as OFCIR (baremetal infra)
participant Test as assisted-capi-test
participant Storage as Artifact Store
Prow->>CI: trigger presubmit (e2e-capi-sno)
CI->>OFCIR: ofcir-acquire (reserve infra)
OFCIR-->>CI: infra details (BMC, IPs)
CI->>Test: assisted-ofcir-setup (provision cluster with SNO env)
Test->>Test: run assisted-capi-test (CLUSTER_TOPOLOGY=sno, NUMBER_OF_NODES=1)
Test->>Storage: upload logs/artifacts
CI->>OFCIR: ofcir-gather (collect diagnostics)
CI->>OFCIR: ofcir-release (release infra)
OFCIR-->>CI: release confirmation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/cc @rccrdpccl |
frajamomo
force-pushed
the
feat/e2e-capi-sno
branch
from
d7b7635 to
e6fd68a
Compare
|
/retest |
|
/pj-rehearse |
|
@frajamomo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ? |
|
@frajamomo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@frajamomo: job(s): ? either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse abort |
|
@frajamomo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
frajamomo
force-pushed
the
feat/e2e-capi-sno
branch
from
e6fd68a to
c4e70ad
Compare
|
/pj-rehearse list |
|
@frajamomo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/step-registry/assisted/ofcir/baremetal/capi/sno/assisted-ofcir-baremetal-capi-sno-workflow.metadata.json`:
- Around line 1-7: The JSON metadata is missing the final closing brace and
trailing newline: close the top-level object that contains the "path" and
"owners" keys by adding the missing '}' at the end of the file and ensure a
trailing newline is present so the file is valid JSON and consistent with
sibling metadata files.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0e2a5c4d-a06a-4bec-b67c-32c4063bdebd
📒 Files selected for processing (7)
ci-operator/config/openshift-assisted/cluster-api-provider-openshift-assisted/openshift-assisted-cluster-api-provider-openshift-assisted-master.yamlci-operator/jobs/openshift-assisted/cluster-api-provider-openshift-assisted/openshift-assisted-cluster-api-provider-openshift-assisted-master-presubmits.yamlci-operator/step-registry/assisted/capi/test/assisted-capi-test-commands.shci-operator/step-registry/assisted/capi/test/assisted-capi-test-ref.yamlci-operator/step-registry/assisted/ofcir/baremetal/capi/sno/OWNERSci-operator/step-registry/assisted/ofcir/baremetal/capi/sno/assisted-ofcir-baremetal-capi-sno-workflow.metadata.jsonci-operator/step-registry/assisted/ofcir/baremetal/capi/sno/assisted-ofcir-baremetal-capi-sno-workflow.yaml
✅ Files skipped from review due to trivial changes (1)
- ci-operator/step-registry/assisted/ofcir/baremetal/capi/sno/OWNERS
🚧 Files skipped from review as they are similar to previous changes (4)
- ci-operator/step-registry/assisted/capi/test/assisted-capi-test-commands.sh
- ci-operator/config/openshift-assisted/cluster-api-provider-openshift-assisted/openshift-assisted-cluster-api-provider-openshift-assisted-master.yaml
- ci-operator/step-registry/assisted/capi/test/assisted-capi-test-ref.yaml
- ci-operator/step-registry/assisted/ofcir/baremetal/capi/sno/assisted-ofcir-baremetal-capi-sno-workflow.yaml
frajamomo
force-pushed
the
feat/e2e-capi-sno
branch
2 times, most recently
from
8357c8f to
df79dbb
Compare
|
/re-test |
Add SNO (Single Node OpenShift) e2e test variant for the cluster-api-provider-openshift-assisted repo, complementing the existing e2e-capi-multinode test. Changes: - Add CLUSTER_TOPOLOGY and NUMBER_OF_NODES env vars to assisted-capi-test ref - Export topology env vars in assisted-capi-test-commands.sh - Create assisted-ofcir-baremetal-capi-sno workflow (medium cluster type) - Add e2e-capi-sno optional test in ci-operator config Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
frajamomo
force-pushed
the
feat/e2e-capi-sno
branch
from
df79dbb to
b8a3884
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-assisted-cluster-api-provider-openshift-assisted-master-e2e-capi-sno |
|
@frajamomo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-assisted-cluster-api-provider-openshift-assisted-master-e2e-capi-multinode |
|
@frajamomo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@frajamomo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@frajamomo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frajamomo, rccrdpccl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
2 participants
Add SNO (Single Node OpenShift) e2e test variant for the cluster-api-provider-openshift-assisted repo, complementing the existing e2e-capi-multinode test.
Changes:
Summary by CodeRabbit
New Features
Chores