Skip to content

Making oc cli case blocking#2260

Open
gangwgr wants to merge 1 commit intoopenshift:mainfrom
gangwgr:rm-infoming
Open

Making oc cli case blocking#2260
gangwgr wants to merge 1 commit intoopenshift:mainfrom
gangwgr:rm-infoming

Conversation

@gangwgr
Copy link
Copy Markdown
Contributor

@gangwgr gangwgr commented Apr 24, 2026 •
edited by coderabbitai Bot
Loading

Making oc cli case blocking

Summary by CodeRabbit

  • Tests
    • Removed an unnecessary test decorator/argument from four end-to-end CLI test registrations, simplifying their declarations. Test descriptions, bodies and behavior are unchanged. Minor formatting adjustments were made to test imports. This reduces boilerplate and clarifies test intent without affecting test outcomes.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ce9f0288-f370-4dbc-8696-79c9de1fb972

📥 Commits

Reviewing files that changed from the base of the PR and between 4fb29f0 and af05403.

📒 Files selected for processing (1)
  • test/e2e/cli.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/e2e/cli.go

Walkthrough

Removed four uses of oteginkgo.Informing() from g.It(...) test registrations in test/e2e/cli.go; adjusted oteginkgo import whitespace. Test bodies, descriptions, and control flow were not modified.

Changes

Cohort / File(s) Summary
Test Decorator Removal
test/e2e/cli.go		 Removed oteginkgo.Informing() arguments from four g.It(...) registrations in the "[sig-cli] oc CLI additional tests" block and made minor whitespace adjustments around the oteginkgo import. No test bodies or descriptions changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 warning, 2 inconclusive)

Check name Status Explanation Resolution
Ipv6 And Disconnected Network Test Compatibility ⚠️ Warning 27 Ginkgo e2e tests added; only 12 (44%) have skipIfDisconnected guards. Tests 49859 and 49116 reference external registries without disconnect protection. Add skipIfDisconnected(oc) guards to tests 49859 and 49116, audit remaining tests for external connectivity dependencies, and add [Skipped:Disconnected] suffix to tests that inherently require external connectivity.
Title check ❓ Inconclusive The title "Making oc cli case blocking" is vague and does not clearly describe the actual changes, which involve removing oteginkgo.Informing() from test registrations to alter test blocking behavior. Consider a more descriptive title such as "Remove oteginkgo.Informing() to make CLI tests blocking" that explicitly indicates what code changed and why.
Ote Binary Stdout Contract ❓ Inconclusive The repository does not contain the modified test/e2e/cli.go file or references to oteginkgo.Informing() required to verify OTE Binary Stdout Contract compliance. Verify that the PR branch is correctly checked out and contains the modified test/e2e/cli.go file with the Informing() removals before reassessing this check.
✅ Passed checks (9 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Test names in the describe block are stable and deterministic, containing only static information with fixed test case IDs and descriptive text that clearly indicate test validation without dynamic values.
Test Structure And Quality ✅ Passed The pull request demonstrates solid adherence to Ginkgo test quality requirements with proper BeforeEach/AfterEach patterns, appropriate timeouts, meaningful assertions, and single responsibility per test.
Microshift Test Compatibility ✅ Passed This PR does not add new Ginkgo e2e tests; it only modifies existing test registrations by removing the oteginkgo.Informing() modifier.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies existing test registrations by removing oteginkgo.Informing() parameter; does not add new Ginkgo e2e tests, so SNO compatibility check for new tests is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies test code by removing decorators; no deployment manifests, operator code, or scheduling constraints introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from ardaguclu and ingvagabund April 24, 2026 07:05
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gangwgr
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 24, 2026

/payload 5.0 nightly blocking

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@gangwgr: trigger 13 job(s) of type blocking for the nightly release of OCP 5.0

  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-upgrade-fips
  • periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-1of2
  • periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-2of2
  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview-serial-1of3
  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview-serial-2of3
  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview-serial-3of3
  • periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-ipv4
  • periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5721ac40-3fae-11f1-8499-d723fdf31cb7-0

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 24, 2026

/test periodic-ci-openshift-microshift-release-5.0-periodics-e2e-aws-ovn-ocp-conformance

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 24, 2026

/payload 5.0 periodic-ci-openshift-microshift-release-5.0-periodics-e2e-aws-ovn-ocp-conformance

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@gangwgr: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 24, 2026

/payload periodic-ci-openshift-microshift-release-5.0-periodics-e2e-aws-ovn-ocp-conformance

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@gangwgr: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 24, 2026

/payload-aggregate periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance 10

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@gangwgr: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0d97eb50-3fb0-11f1-99d7-e99a342fdaf4-0

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 24, 2026

/payload-aggregate periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance 10

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@gangwgr: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/399954a0-3fb0-11f1-82b4-8b04e4563fbf-0

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 24, 2026

/payload-aggregate periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-serial 10

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@gangwgr: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 24, 2026

/payload-aggregate periodic-ci-openshift-microshift-release-5.0-periodics-e2e-aws-ovn-ocp-conformance 10

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@gangwgr: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-microshift-release-5.0-periodics-e2e-aws-ovn-ocp-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/73f9c9e0-3fb0-11f1-913c-b674c7e1611d-0

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 24, 2026

/payload-aggregate periodic-ci-openshift-microshift-release-5.0-periodics-e2e-aws-ovn-ocp-serial 10

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@gangwgr: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 24, 2026

/payload-aggregate periodic-ci-openshift-microshift-release-5.0-periodics-e2e-aws-ovn-ocp-conformance-serial 10

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@gangwgr: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-microshift-release-5.0-periodics-e2e-aws-ovn-ocp-conformance-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/86af6840-3fbc-11f1-8c0a-9cdcc52ec943-0

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 24, 2026

/payload-aggregate periodic-ci-openshift-microshift-release-4.22-periodics-e2e-aws-ovn-ocp-conformance-serial 10

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@gangwgr: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-microshift-release-4.22-periodics-e2e-aws-ovn-ocp-conformance-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6832b6d0-3fc4-11f1-95ca-8243528d7519-0

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 24, 2026

/payload-aggregate periodic-ci-openshift-microshift-release-4.22-periodics-e2e-aws-ovn-ocp-conformance 10

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@gangwgr: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-microshift-release-4.22-periodics-e2e-aws-ovn-ocp-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/73f3bf50-3fc4-11f1-9437-e9aa44bb1a2a-0

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 27, 2026

/payload 5.0 nightly blocking

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 27, 2026

@gangwgr: trigger 13 job(s) of type blocking for the nightly release of OCP 5.0

  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-upgrade-fips
  • periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-1of2
  • periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-serial-2of2
  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview-serial-1of3
  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview-serial-2of3
  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview-serial-3of3
  • periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-ipv4
  • periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8e53f460-4211-11f1-89c0-64468b05941d-0

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 27, 2026

/payload-aggregate periodic-ci-openshift-microshift-release-4.22-periodics-e2e-aws-ovn-ocp-conformance 10

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 27, 2026

@gangwgr: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-microshift-release-4.22-periodics-e2e-aws-ovn-ocp-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/93191d90-4211-11f1-814c-d55a83c7d6b3-0

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 27, 2026

/payload-aggregate periodic-ci-openshift-microshift-release-4.22-periodics-e2e-aws-ovn-ocp-conformance-serial 10

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 27, 2026

@gangwgr: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-microshift-release-4.22-periodics-e2e-aws-ovn-ocp-conformance-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9b9bc3f0-4211-11f1-8138-b9e481da48f7-0

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Apr 27, 2026

/test verify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gangwgr