Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets faster shutdowns in lightNVR by reducing waits during teardown and avoiding waiting on components that were never registered with the shutdown coordinator.
Changes:
- Attempts to wake sleeping background threads during shutdown using
pthread_kill()so they can exit promptly. - Adjusts shutdown coordinator initialization/registration so
wait_for_all_components_stopped()doesn’t wait when nothing was registered. - Removes a couple of duplicate shutdown log lines and tweaks a startup wait loop sleep interval.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/web/api_handlers_health.c | Wakes health-check thread during shutdown to reduce stop latency. |
| src/video/mp4_writer_thread.c | Reduces CPU usage in thread-start wait loop by increasing sleep interval. |
| src/telemetry/stream_metrics.c | Wakes metrics sampler thread during shutdown for faster exit. |
| src/database/db_recordings_sync.c | Wakes recordings sync thread during shutdown for faster exit. |
| src/core/shutdown_coordinator.c | Initializes coordinator as “all stopped” until a component registers; improves logging loop stability. |
| src/core/mqtt_client.c | Wakes MQTT HA background threads during stop/failure cleanup. |
| src/core/main.c | Removes duplicate shutdown log lines around MP4/HLS cleanup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
596
to
600
| g_health_thread_running = false; | ||
| pthread_kill(g_health_check_thread, SIGALRM); | ||
| sched_yield(); | ||
|
|
||
| // Use portable polling approach with timeout (5 seconds) |
Comment on lines
199
to
204
| if (g_sampler_running) { | ||
| g_sampler_running = false; | ||
| pthread_kill(g_sampler_thread, SIGALRM); | ||
| sched_yield(); | ||
|
|
||
| pthread_join(g_sampler_thread, NULL); |
Comment on lines
297
to
301
| sync_thread.running = false; | ||
| pthread_mutex_unlock(&sync_thread.mutex); | ||
| pthread_kill(sync_thread.thread, SIGALRM); | ||
|
|
||
| // Wait for thread to exit |
Comment on lines
982
to
+987
| log_error("MQTT HA: Failed to create motion timeout thread"); | ||
| // Signal any already-started HA service threads to stop | ||
| ha_services_running = false; | ||
| pthread_kill(ha_snapshot_thread, SIGALRM); | ||
| sched_yield(); | ||
|
|
Comment on lines
1009
to
+1012
| ha_services_running = false; | ||
| pthread_kill(ha_snapshot_thread, SIGALRM); | ||
| pthread_kill(ha_motion_thread, SIGALRM); | ||
| sched_yield(); |
Comment on lines
+597
to
599
| pthread_kill(g_health_check_thread, SIGALRM); | ||
| sched_yield(); | ||
|
|
Comment on lines
+597
to
+598
| pthread_kill(g_health_check_thread, SIGALRM); | ||
| sched_yield(); |
Comment on lines
+201
to
+203
| pthread_kill(g_sampler_thread, SIGALRM); | ||
| sched_yield(); | ||
|
|
Comment on lines
+985
to
+987
| pthread_kill(ha_snapshot_thread, SIGALRM); | ||
| sched_yield(); | ||
|
|
Contributor
Author
|
I thought |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shutting down lightNVR can take 15-20 seconds, which sometimes makes development more tedious than necessary. This PR cleans up some of the more egregious shutdown delays by signalling threads so they wake up from
sleep()and properly initializing the shutdown manager so it doesn't wait for components that were never registered. A few duplicate log lines are also removed.