Merged
Conversation
Member
Author
|
vendorverify fails on Windows because it's running a shell script--I'll adjust the platform restriction for that. |
Several environments were restricted to running only on Linux. I'm not really sure why and it prevents me from running tests on macOS. I changed the restriction to run on Linux and Darwin. vendorverify definitely won't run on Windows, so we need to restrict that.
willkg
force-pushed
the
fix-tox-platform-restrictions
branch
from
0ca6e97 to
7b84681
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several environments were restricted to running only on Linux. I'm not really sure why and it prevents me from running tests on macOS. I removed the restriction to see if it passes CI. If it does, we'll keep this fix.