Update makeself-header.sh to better handle relative paths and provide…#328
Open
poliphant wants to merge 3 commits intomegastep:masterfrom
Open
Update makeself-header.sh to better handle relative paths and provide…#328poliphant wants to merge 3 commits intomegastep:masterfrom
poliphant wants to merge 3 commits intomegastep:masterfrom
Conversation
… a launching script name to a startup_script Update the ARCHIVE_DIR variable to provide an absolute path even when the makeself script is launched with a relative path. An absolute path is needed when the startup script is ask to place folder and files in a directory relative to the makeself script location. Add the ARCHIVE_BASE variable. This provides the name of the originating makeself script. This is useful to provide feedback to the user in for example 'usage' messages.
Owner
|
Interesting idea, however it seems to break a number of our tests at the moment. |
Author
|
What can I do to help this change pass the tests it is failing?
…On Fri, Apr 12, 2024, 6:09 PM Stéphane Peter ***@***.***> wrote:
Interesting idea, however it seems to break a number of our tests at the
moment.
—
Reply to this email directly, view it on GitHub
<#328 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHZFKWOFWYIBZAIX3X5432TY5BSRZAVCNFSM6AAAAABGE4HKVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJSGY3TENBRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
Try to run the tests yourself ( |
Owner
|
FYI, the variable test seems to be the main culprit. |
megastep
requested changes
Apr 13, 2024
| USER_PWD="\$PWD" | ||
| export USER_PWD | ||
| ARCHIVE_DIR=\`dirname "\$0"\` | ||
| ARCHIVE_DIR=\$( cd -- "\$(dirname "\$0")" >/dev/null 2>&1 ; echo \$PWD ) |
Owner
There was a problem hiding this comment.
One problem here is that the $() syntax is a modern bash-ism which is not very portable (unlike the backtick approach).
replaced with back ticks for better backward compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… a launching script name to a startup_script
Update the ARCHIVE_DIR variable to provide an absolute path even when the makeself script is launched with a relative path. An absolute path is needed when the startup script is ask to place folder and files in a directory relative to the makeself script location.
Add the ARCHIVE_BASE variable. This provides the name of the originating makeself script. This is useful to provide feedback to the user in for example 'usage' messages.