messagix/bloks: support bk.action.core.Let#264
Open
iFixRobots wants to merge 1 commit intomainfrom
Open
Conversation
iFixRobots
requested review from
radon-at-beeper and
tulir
and removed request for
radon-at-beeper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing
bk.action.core.Letopcode. Without it, the Messenger Lite login flow fails on the email/password screen withtapping login button: on_touch_down: unimplemented function bk.action.core.Let (2 args)— Facebook's login script started usingLetto lazy-init per-screen animation state.Let(currentOrNull, FuncConst(initializer)): ifcurrentOrNullevaluates to a non-null value (a previously cached value), return it; otherwise apply the FuncConst lambda in arg 1 and return its result. Implementation matches the existingCoalescepattern plus theApplylambda invocation.Reproduced and verified against a real captured bundle: the on_touch_down handler now executes through to
com.bloks.www.bloks.caa.login.async.send_login_requestcleanly viapkg/messagix/bloks/cmd -file <bundle> -action -login.Closes PLAT-36280.