Use static ops and avoid null argument when creating geom#217
Open
bjornharrtell wants to merge 2 commits intolocationtech:masterfrom
Open
Use static ops and avoid null argument when creating geom#217bjornharrtell wants to merge 2 commits intolocationtech:masterfrom
bjornharrtell wants to merge 2 commits intolocationtech:masterfrom
Conversation
Contributor
|
So is #200 cancelled? |
Contributor
|
This is a lot of changes. The null arg change could be a separate PR. |
Contributor
Author
Contributor
|
Ok, thanks for making that clear. |
This was referenced Nov 13, 2017
Contributor
|
@bjornharrtell @dr-jts should this PR be reviewed? |
Contributor
Author
|
No, this depends entirely on #200. |
Signed-off-by: Björn Harrtell <bjorn@wololo.org>
…ethods Signed-off-by: Björn Harrtell <bjorn@wololo.org>
bjornharrtell
force-pushed
the
geom-prec-refactor
branch
from
6cf8841 to
210c5cc
Compare
Contributor
Author
|
Rebased on the recently rebased https://github.com/bjornharrtell/jts/tree/refactor-ops branch (PR #200). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to make GeometryPrecisionReducer work in JSTS transpilation.
Previously also required #213 but I have been able to resolve that in transpilation.
Builds on #200. That PR should be merged first.