Conversation
sjaeckel
approved these changes
Apr 23, 2026
Member
sjaeckel
left a comment
sjaeckel
left a comment
There was a problem hiding this comment.
LGTM
@sjlombardo what do you think?
Contributor
|
Agreed, this looks great and will be nice to extend this to FreeBSD! |
sjaeckel
force-pushed
the
pr/gcm-freebsd
branch
from
8c9bea3 to
e63dca1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for this type of build failure (seen on FreeBSD/arm64)
AFAIK
asm/hwcap.his a Linux kernel userspace API header, therefore guarded byif defined(__linux__)