Fix invalid YAML syntax in default-http-backend image placeholder#3089
Open
FelipeYepez wants to merge 1 commit intokubernetes:masterfrom
Open
Fix invalid YAML syntax in default-http-backend image placeholder#3089FelipeYepez wants to merge 1 commit intokubernetes:masterfrom
FelipeYepez wants to merge 1 commit intokubernetes:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FelipeYepez The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Contributor
Author
|
/assign @kl52752 |
Changes the [IMAGE_URL] array placeholder to the valid string "IMAGE_URL" so kubectl apply does not fail locally. Also updates the README to explain that users must provide their own multi-arch image, as the project no longer publishes a default backend image.
FelipeYepez
changed the title
FelipeYepez
force-pushed
the
fix-default-backend-image
branch
from
cd111de to
8a269c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
[IMAGE_URL]placeholder indefault-http-backend.yamlwas causingkubectl applyto fail with a syntax error during local development (hack/run-local-glbc.sh).The PR also updates the README to explicitly inform users that they must build and provide their own multi-arch backend image, as the project no longer publishes a default one (#1719).