fix(neg): correct 'occured' -> 'occurred' in label-propagation doc comments#3086
fix(neg): correct 'occured' -> 'occurred' in label-propagation doc comments#3086SAY-5 wants to merge 1 commit intokubernetes:masterfrom
Conversation
…mments Two doc comments in pkg/neg used 'occured' instead of 'occurred': * pkg/neg/metrics/metrics.go:340 — PublishLabelPropagationError * pkg/neg/syncers/labels/labels.go:93 — publishLabelPropagationTruncationMetrics Both are doc-only changes. go build ./pkg/neg/... stays clean.
|
|
Welcome @SAY-5! |
|
Hi @SAY-5. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SAY-5, TortillaZHawaii The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Two doc comments in
pkg/negusedoccuredinstead ofoccurred:pkg/neg/metrics/metrics.go:340—PublishLabelPropagationErrorpkg/neg/syncers/labels/labels.go:93—publishLabelPropagationTruncationMetricsBoth are doc-only changes.
go build ./pkg/neg/...stays clean against currentmaster.