feat: Add option to dump and load database snapshots, while keeping relationships on foreign tables.#1873
Draft
alanpeixinho wants to merge 1 commit intokernelci:mainfrom
Draft
feat: Add option to dump and load database snapshots, while keeping relationships on foreign tables.#1873alanpeixinho wants to merge 1 commit intokernelci:mainfrom
alanpeixinho wants to merge 1 commit intokernelci:mainfrom
Conversation
relationships on foreign tables.
alanpeixinho
force-pushed
the
feat/snapshot_command
branch
from
3278ffd to
57707a2
Compare
Collaborator
MarceloRobert
left a comment
MarceloRobert
left a comment
There was a problem hiding this comment.
looks ok, I'll test later
Comment on lines
+239
to
+240
| f"""Unknown table '{table}'. | ||
| Valid options are: issues, checkouts, builds, tests, incidents.""" |
Collaborator
There was a problem hiding this comment.
You could make a template string and reuse between commands. You can save something like myvar = "table is %(tablename)s" and then use as print(myvar % {"tablename": "issues"})
Contributor
Author
There was a problem hiding this comment.
It is a copy/paste from the existing error message. But I plan to refactor regardless
| ] + self.origins | ||
|
|
||
| with self.kcidb_connection.cursor() as kcidb_cursor: | ||
| with connection.cursor() as kcidb_cursor: |
Collaborator
There was a problem hiding this comment.
prefer connections['default']
Collaborator
There was a problem hiding this comment.
also other occurrences in the file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include a command to dump and load database snapshots.