Fix missing function call in is_torch_xla_version#13549
Open
Ricardo-M-L wants to merge 1 commit intohuggingface:mainfrom
Open
Fix missing function call in is_torch_xla_version#13549Ricardo-M-L wants to merge 1 commit intohuggingface:mainfrom
Ricardo-M-L wants to merge 1 commit intohuggingface:mainfrom
Conversation
`is_torch_xla_available` is a function but was referenced without parentheses, checking the truthiness of the function object (always True) instead of its return value. This means the guard never triggers and the version comparison proceeds even when torch_xla is unavailable. Use `_torch_xla_available` (the module-level variable) for consistency with `is_transformers_version`, `is_accelerate_version`, and other version checkers in the same file. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug in
is_torch_xla_version()whereis_torch_xla_available(a function) is referenced without parentheses. This checks the truthiness of the function object itself (alwaysTrue) rather than calling it, so the guard never triggers whentorch_xlais unavailable.The bug
The fix uses
_torch_xla_available(the module-level boolean) for consistency withis_transformers_version,is_accelerate_version, and all otheris_*_versionfunctions in the same file.Who can review?
@yiyixuxu @DN6