refactor: Convert many helper files from PrototypeJS to vanilla JS#32
Open
ralflang wants to merge 5 commits intoFRAMEWORK_6_0from
Open
refactor: Convert many helper files from PrototypeJS to vanilla JS#32ralflang wants to merge 5 commits intoFRAMEWORK_6_0from
ralflang wants to merge 5 commits intoFRAMEWORK_6_0from
Conversation
ralflang
force-pushed
the
refactor/vanilla-js-migration
branch
from
21d86c7 to
3524fb3
Compare
Testing showed we break at unexpected places when we change from fire() to dispatchEvent() without first migrating ALL consumers. Let's take one step back and concentrate on event receivers/consumers and on technicalities nothing outside reasonably depends on.
ralflang
force-pushed
the
refactor/vanilla-js-migration
branch
from
12ad7e8 to
48bb7ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.