Skip to content

s2 should see its status as alive after fixing issue #18 #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbver wants to merge 2 commits into
base: master
Choose a base branch
from
Open

s2 should see its status as alive after fixing issue #18 #738

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bcd5a5
s2 should see its status as alive after fixing issue #18
mbver Aug 20, 2024
033ad70
test for s1 members should not be removed
mbver Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions serf/serf_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1699,16 +1699,29 @@ func TestSerf_joinLeaveJoin(t *testing.T) {
r.Fatalf("s2 members: %d", s2.NumNodes())
}

// s1 should see the node as alive
// s1 should see the all nodes as alive
mems := s1.Members()
anyLeft := false
anyNotAlive := false
for _, m := range mems {
if m.Status == StatusLeft {
anyLeft = true
if m.Status != StatusAlive {
anyNotAlive = true
break
}
}
if anyNotAlive {
r.Fatalf("all nodes should be alive!")
}

// s2 should see the all nodes as alive
mems = s2.Members()
anyNotAlive = false
for _, m := range mems {
if m.Status != StatusAlive {
anyNotAlive = true
break
}
}
if anyLeft {
if anyNotAlive {
r.Fatalf("all nodes should be alive!")
}
})
Expand Down