Draft
Conversation
…/target-loading-architecture
…ic/operator into feature/limit-target-loading
…com/gnmic/operator into feature/limit-target-loading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces per target channel buffering with a snapshot- vs. event-based discovery approach. It also introduces a generic registry that is being used to communicate between the apiserver (webhook) and the target applier.
Core
internal/controller/discovery/core/message_interface.go: Discovery messages become typed unions.internal/controller/discovery/core/types.go: Adjusted types to support the DiscoveryMessage abstraction (e.g., DiscoveredTarget, DiscoverySnapshot, DiscoveryEvent, EventAction).internal/controller/discovery/core/helpers.go: New helpers that convert target slices into chunked DiscoverySnapshot messages and send []DiscoveryMessage with context-aware semantics. Implements SendSnapshot and SendEvents.Target applier (renamed from target manager)
internal/controller/discovery/target_applier.go: Updated to use the new DiscoveryMessage interface; handles both DiscoverySnapshot and DiscoveryEvent via type assertion/dispatch.Controller wiring & refactor
internal/controller/targetsource_controller.go: Reconciler refactor to improve clarity.Generic Registry
internal/controller/discovery/registry/registry.go: A generic implementation of a registry providing functions like NewRegistry, Register and Unregister