Fix github repository setup to correctly detect and configure required checks#1753
Open
TheoBrigitte wants to merge 3 commits intomainfrom
Open
Fix github repository setup to correctly detect and configure required checks#1753TheoBrigitte wants to merge 3 commits intomainfrom
TheoBrigitte wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
devctl repo setupcommand was not correctly configuring required check on the default branch.Summary
GetCombinedStatustoListCheckRunsForRefAPI to correctly detect required status checks when configuring branch protection--checks-filterfromaliyuntocreate-releaseto exclude the release workflow from required checksTests
I've managed to configure checks on the a repo using
devctl repo setup giantswarm/some-repo--log-level debugBefore
After