Skip to content

ref(openai): Separate sync and async embeddings patches#6189

Open
alexander-alderman-webb wants to merge 3 commits intowebb/openai/separate-sync-and-async-responsesfrom
webb/openai/separate-sync-and-async-embeddings
Open

ref(openai): Separate sync and async embeddings patches#6189
alexander-alderman-webb wants to merge 3 commits intowebb/openai/separate-sync-and-async-responsesfrom
webb/openai/separate-sync-and-async-embeddings

Conversation

@alexander-alderman-webb
Copy link
Copy Markdown
Contributor

@alexander-alderman-webb alexander-alderman-webb commented May 4, 2026

Description

Remove generator pattern to allow capturing exception info on AI Client Spans in upcoming PRs.

Issues

Reminders

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Codecov Results 📊

6 passed | Total: 6 | Pass Rate: 100% | Execution Time: 2.41s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

❌ Patch coverage is 0.00%. Project has 16976 uncovered lines.
❌ Project coverage is 21.91%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
openai.py 4.30% ⚠️ 645 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    22.13%    21.91%    -0.22%
==========================================
  Files          190       190         —
  Lines        21758     21739       -19
  Branches      7288      7296        +8
==========================================
+ Hits          4814      4763       -51
- Misses       16944     16976       +32
- Partials       386       382        -4

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review May 4, 2026 07:04
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner May 4, 2026 07:04
Comment thread sentry_sdk/integrations/openai.py Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d49cfac. Configure here.

Comment thread sentry_sdk/integrations/openai.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants