[file_selector] Update Windows example for deprecations#11570
[file_selector] Update Windows example for deprecations#11570stuartmorgan-g wants to merge 1 commit intoflutter:mainfrom
Conversation
The `file_selector_windows example was using some methods that have been deprecated in favor of param-object versions. This updates to use those new versions.
stuartmorgan-g
added
the
override: no changelog needed
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
text-exempt: refactor with no semantic change |
|
I'm not sure how I missed this when I made the same fix to the Linux version back in #10542 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the file_selector_windows example to use the getDirectoryPathWithOptions and getDirectoryPathsWithOptions methods, replacing the previous getDirectoryPath and getDirectoryPaths calls. The file_selector_platform_interface dependency in the example's pubspec.yaml is also updated to version ^2.7.0. I have no feedback to provide.
1 participant
The
file_selector_windowsexample was using some methods that have been deprecated in favor of param-object versions. This updates to use those new versions.