Skip to content

[video_player_android] Bump gradle plugin to 9.1.1#11558

Open
camsim99 wants to merge 1 commit intoflutter:mainfrom
camsim99:update-gradle-plugin-video_player_android
Open

[video_player_android] Bump gradle plugin to 9.1.1#11558
camsim99 wants to merge 1 commit intoflutter:mainfrom
camsim99:update-gradle-plugin-video_player_android

Conversation

@camsim99
Copy link
Copy Markdown
Contributor

Bumps com.android.tools.build:gradle from 8.13.1 to 9.1.1 in packages/video_player/video_player_android.

@flutter-dashboard
Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the video_player_android package to version 2.9.6, which includes bumping the Android Gradle Plugin from 8.13.1 to 9.1.1. A review comment suggests that this major version upgrade may require corresponding updates to the Gradle wrapper and the JDK version to ensure build compatibility.


dependencies {
classpath("com.android.tools.build:gradle:8.13.1")
classpath("com.android.tools.build:gradle:9.1.1")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Bumping the Android Gradle Plugin (AGP) to a major version (9.x) typically requires a corresponding update to the Gradle wrapper version (to 9.0 or higher) and the JDK version used to run the build (to JDK 21 or higher). While the compileOptions can remain at Java 17, the build environment itself must be compatible with AGP 9.x requirements to avoid build failures.

@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants