[google_maps_flutter_android] Bump gradle plugin to 9.1.1#11556
[google_maps_flutter_android] Bump gradle plugin to 9.1.1#11556camsim99 wants to merge 1 commit intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Android Gradle Plugin from version 8.13.1 to 9.1.1 and increments the package version to 2.19.9. The reviewer suggests that a minor version bump to 2.20.0 is more appropriate for a major dependency update and recommends updating the changelog accordingly.
| repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_android | ||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22 | ||
| version: 2.19.8 | ||
| version: 2.19.9 |
There was a problem hiding this comment.
Bumping the Android Gradle Plugin (AGP) from a major version (8.x to 9.x) is a significant change that may impose new requirements on the consuming application's build environment (such as a minimum Gradle version). Following semantic versioning, a minor version bump (e.g., 2.20.0) is generally more appropriate for major dependency updates that could affect the build process of users, rather than a patch bump (2.19.9).
version: 2.20.0| @@ -1,3 +1,7 @@ | |||
| ## 2.19.9 | |||
There was a problem hiding this comment.
If the version is changed to 2.20.0 in pubspec.yaml to reflect the major AGP bump, the changelog header should be updated accordingly.
| ## 2.19.9 | |
| ## 2.20.0 |
2 participants
Bumps com.android.tools.build:gradle from 8.13.1 to 9.1.1 in packages/google_maps_flutter/google_maps_flutter_android.