fix(credentials): Persist credential selection#119
Merged
Conversation
Code Review SummaryThe PR addresses a bug where registry credentials were not persisted if the service lacked other metadata (like SSL or networking configs). 🚀 Key Improvements
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
|
|
||
| } | ||
|
|
||
| if req.Metadata != nil && (credentialID != "" || len(req.ServiceCredentials) > 0) { |
There was a problem hiding this comment.
By initializing req.Metadata when it's nil but credentials exist, we ensure that registry associations are persisted. This fixes the bug where deployments without networking metadata would lose their credential links. Ensure models.ServiceMetadata does not require additional mandatory fields other than Name.
Suggested change
| if req.Metadata != nil && (credentialID != "" || len(req.ServiceCredentials) > 0) { | |
| + if credentialID != "" || len(req.ServiceCredentials) > 0 { | |
| + if req.Metadata == nil { | |
| + req.Metadata = &models.ServiceMetadata{Name: req.Name} | |
| + } |
Deployments created with a registry credential but no networking or SSL metadata (for example, internal services without an exposed domain) were silently dropped by the agent, so the detail view later showed them as "Public" and subsequent pulls reverted to Docker Hub. The agent now persists registry credential selections unconditionally when one is present, ensuring the association survives across restarts and rebuilds regardless of whether other metadata fields were provided. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/persist-credential-id-without-metadata
branch
from
c78e52c to
277b8f3
Compare
nfebe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployments created with a registry credential but no networking or SSL metadata (for example, internal services without an exposed domain) were silently dropped by the agent, so the detail view later showed them as "Public" and subsequent pulls reverted to Docker Hub.
The agent now persists registry credential selections unconditionally when one is present, ensuring the association survives across restarts and rebuilds regardless of whether other metadata fields were provided.