Refactoring create_db.py#153
Closed
bralbral wants to merge 8 commits intofirefart:mainfrom
Closed
Conversation
Owner
|
Why did you remove all comments and the whole last_modified fallback? |
Added custom separator; fix errors;
Contributor
Author
Sorry about that, my bad. I have re-added them. Also, I have added an environment variable to connect to the database. Additionally, export in |
Owner
|
please make single pull requests with small changes instead of those big ones. This is too much to review and test at once |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
The old version of the
create_db.pycode crashes with a divide-by-zero error.Some logs:
After refactoring the code, I fixed it and also eliminated the use of
globalvariables.