[release/10.0] Fix IJW OverflowException with 17+ by-ref parameters#127342
Open
github-actions[bot] wants to merge 6 commits intorelease/10.0from
Open
[release/10.0] Fix IJW OverflowException with 17+ by-ref parameters#127342github-actions[bot] wants to merge 6 commits intorelease/10.0from
github-actions[bot] wants to merge 6 commits intorelease/10.0from
Conversation
StubSigBuilder::EnsureEnoughQuickBytes only doubled the buffer size once, so when the required size exceeded 2x the current buffer, the CQuickBytes inline buffer (512 bytes) overflowed into the adjacent m_nItems field. This was triggered by PR #106000 which changed ConvertToInternalSignature to preserve custom modifiers (bSkipCustomModifier=FALSE). Each preserved modifier adds 10 bytes (ELEMENT_TYPE_CMOD_INTERNAL + required byte + 8-byte TypeHandle pointer) to the signature. For 18+ parameters with custom modifiers, the total signature exceeded 512 bytes, causing a buffer overflow that corrupted m_nItems and led to an OverflowException. The fix loops the doubling until the buffer is large enough. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Use S_SIZE_T for checked arithmetic in EnsureEnoughQuickBytes to prevent infinite loop or undersized allocation on SIZE_T overflow. - Remove unnecessary NativeSum18ByRefEntryPoint DLL export. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
AaronRobinsonMSFT
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #127182 to release/10.0
/cc @jkoritzinsky
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.