[6.x] Fixes user settings for solo edition#18778
Merged
brianjhanson merged 2 commits into6.xfrom May 1, 2026
Merged
Conversation
|
Review changes with |
riasvdv
approved these changes
May 1, 2026
riasvdv
reviewed
May 1, 2026
| if (Edition::isAtLeast(Edition::Team)) { | ||
| Route::get('settings/users', [UserGroupsController::class, 'index']); | ||
| } else { | ||
| Route::get('settings/users', fn () => redirect(cp_url('settings/users/fields'))); |
Contributor
There was a problem hiding this comment.
We could also use Route::redirect( but either is fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While clicking around I noticed that clicking the
usersitem when using the solo edition would result in a "Not found" error.It turns out the
settings/usersroute was only defined for team versions and up, but Solo still uses it in v5.I played with a handful of approaches but this one seemed to work best despite not being my favorite.
Feel free to let me know if there's a better way to do this.