[6.x] don't use php.ini file for the backup test command#18754
Draft
[6.x] don't use php.ini file for the backup test command#18754
Conversation
i-just
changed the title
i-just
changed the title
i-just
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I’m using
ddevlocally. When I run the whole suite of tests viaddev exec --dir /var/www/html/vendor/craftcms/cms ./vendor/bin/pest, it’ll hang after completing thetests/Feature/Dashboard/Widgets/WidgetTest.phptest.The next test file in line is
tests/Feature/Database/BackupsTest.php, and runningddev exec --dir /var/www/html/vendor/craftcms/cms ./vendor/bin/pest tests/Feature/Database/BackupsTest.phpjust hangs.Long story short, the solution seems to be to add the
-nparam to the backup command, which will cause nophp.inifile to be used in the command.Is anyone else having this issue?
Does anyone have an opinion on whether the proposed change is safe in our case?
Related issues
n/a