Fix #6492 valueflow: for loop condition not used for conditional analysis#8472
Open
chrchr-github wants to merge 13 commits intocppcheck-opensource:mainfrom
Open
Fix #6492 valueflow: for loop condition not used for conditional analysis#8472chrchr-github wants to merge 13 commits intocppcheck-opensource:mainfrom
chrchr-github wants to merge 13 commits intocppcheck-opensource:mainfrom
Conversation
|
danmar
reviewed
Apr 26, 2026
| if (const Token* parent = tok->astParent()) { | ||
| if (Token::Match(parent, "%oror%|&&|?") || | ||
| Token::Match(parent->previous(), "if|while (") || | ||
| (parent->str() == ";" && Token::simpleMatch(parent->astParent(), ";"))) { |
Collaborator
There was a problem hiding this comment.
if parent is ; we also should check that tok is the LHS of parent right? (astIsLHS).
danmar
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged after #8471.
Ignoring the debug messages since the line numbers were flaky.