Conversation
adamcfraser
requested changes
May 5, 2026
| } | ||
| checkpointPrefix := GetResyncDCPCheckpointPrefix(db.DatabaseContext, resyncID, r.Distributed) | ||
| if !r.Distributed { | ||
| dcpClient, err := r.newDCPClient(ctx, db, false) |
Collaborator
There was a problem hiding this comment.
newDCPClient seems like it does a decent amount of setup work (including loading and initializing metadata from the checkpoints we're about to delete). Is this just to handle the differences in purge between Rosmar and Gocb implementations?
Any way of having an equivalent function to base.PurgeShardedDCPCheckpoints for non-sharded feeds that accepts a MetadataStore and numWorkers?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5175: resync - purge checkpoints if needed
Create a function to
PurgeShardedDCPCheckpointsthat can be called when necessary. Currently wired up to purge whenever we purged the existing code. I tried this style of purging for attachment migration and compaction and somehow some subtle timing differences surface bugs in the code I don't want to uncover. There's a future jira ticket for this.It's expected that in Sync Gateway 4.1, EE will use distributed mode and CE will use non distributed mode which is why both pathways are present.
I do not yet purge the checkpoints when the feed completes normally as I do not have the code in cbgt or hooks to determine when that is.
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests