[16.0][MIG] pos_customer_wallet by carmenbianca · Pull Request #300 · coopiteasy/addons

carmenbianca · 2023-07-11T14:13:55Z

Description

Odoo task (if applicable)

https://gestion.coopiteasy.be/web#id=10799&action=475&active_id=492&model=project.task&view_type=form&menu_id=536

Checklist before approval

Tests are present (or not needed).
Credits/copyright have been changed correctly.
Change log snippet is present.
(If a new module) Moving this to OCA has been considered.

codecov-commenter · 2023-09-07T09:49:12Z

Codecov Report

Merging #300 (8772350) into 16.0 (b640076) will decrease coverage by 3.22%.
Report is 19 commits behind head on 16.0.
The diff coverage is 86.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             16.0     #300      +/-   ##
==========================================
- Coverage   97.73%   94.52%   -3.22%     
==========================================
  Files          12       26      +14     
  Lines         221      347     +126     
  Branches       30       39       +9     
==========================================
+ Hits          216      328     +112     
- Misses          1       15      +14     
  Partials        4        4

Files Changed	Coverage Δ
pos_customer_wallet/models/pos_session.py	`40.00% <40.00%> (ø)`
pos_customer_wallet/models/pos_config.py	`58.33% <58.33%> (ø)`
account_customer_wallet/tests/common.py	`94.11% <100.00%> (+0.17%)`	⬆️
pos_customer_wallet/__init__.py	`100.00% <100.00%> (ø)`
pos_customer_wallet/models/__init__.py	`100.00% <100.00%> (ø)`
pos_customer_wallet/models/pos_payment_method.py	`100.00% <100.00%> (ø)`
pos_customer_wallet/models/res_partner.py	`100.00% <100.00%> (ø)`
pos_customer_wallet/tests/__init__.py	`100.00% <100.00%> (ø)`
pos_customer_wallet/tests/common.py	`100.00% <100.00%> (ø)`
pos_customer_wallet/tests/test_balance.py	`100.00% <100.00%> (ø)`

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

carmenbianca · 2023-09-08T13:18:01Z

I think this is ported as far as I'm going to be able to port it for the moment.

Some notes:

I removed base_suspend_security as a dependency. @legalsylvain I know that you introduced this dependency, and I think it had to do with multi-company support, but I cannot well remember why it was there. There should be a test for the use case.
I did not test multi-company support.
I did a decent amount of functional testing, but I doubtlessly missed some spots.
I didn't test toggling off the is_enabled_customer_wallet button.
I should probably write tests for the JavaScript…

legalsylvain · 2023-09-08T15:05:50Z

Thanks a lot !

I should probably write tests for the JavaScript…

;-)

I removed base_suspend_security as a dependency. @legalsylvain I know that you introduced this dependency, and I think it had to do with multi-company support, but I cannot well remember why it was there. There should be a test for the use case.

let's start like that, and see if we face some issue.

legalsylvain · 2023-09-15T13:31:14Z

Is it ready to review ?

carmenbianca · 2023-09-18T11:37:49Z

@legalsylvain yes, i think!

carmenbianca · 2023-09-18T13:33:22Z

Problem found during functional testing: The balance is not reduced when making POS payments with the child of a partner. Needs further investigation.

co-authored-by: hugues de keyzer <odoo@hugues.info>

* replace "save" and "discard" default buttons of the details wizard by a "close" button. * improve styling of the buttons of the redistribute wizard. * fix xml indentation.

* fix alignment of amount and balance column values. * use t-else instead of opposite test. * replace t-esc by t-out.

* rename model classes to match filename. * remove empty lines between field definitions.

* simplify javascript code. * improve user messages. * replace t-esc by t-out.

add known issue about sequence of operations to the roadmap.

improve fr translation.

use a more sober and simple styling to display the customer wallet amount on the pos payment screen.

format datetime as a date (since coming from account.move.line it has no time) (taking the locale into account) in the customer wallet detail wizard.

huguesdk · 2026-04-28T16:16:38Z

/ocabot merge nobump

github-grap-bot · 2026-04-28T16:16:45Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-300-by-huguesdk-bump-nobump, awaiting test results.

github-grap-bot · 2026-04-28T16:27:54Z

Congratulations, your PR was merged at 4d7989d. Thanks a lot for contributing to coopiteasy. ❤️

carmenbianca changed the title ~~[16.0][MIGpos customer wallet~~ [16.0][MIG] pos_customer_wallet Jul 11, 2023

carmenbianca marked this pull request as draft July 11, 2023 14:14

carmenbianca force-pushed the 16.0-mig-pos_customer_wallet branch from 06ace62 to 1109db1 Compare September 7, 2023 09:38

github-grap-bot added the needs review label Sep 7, 2023

carmenbianca force-pushed the 16.0-mig-pos_customer_wallet branch from 1109db1 to afb08db Compare September 7, 2023 09:46

carmenbianca force-pushed the 16.0-mig-pos_customer_wallet branch 4 times, most recently from ab9eb4c to f340fcf Compare September 8, 2023 12:44

carmenbianca marked this pull request as ready for review September 8, 2023 13:01

carmenbianca assigned huguesdk, robinkeunen, remytms and victor-champonnois Sep 8, 2023

legalsylvain reviewed Sep 8, 2023

View reviewed changes

Comment thread pos_customer_wallet/models/res_partner.py Outdated

carmenbianca unassigned huguesdk, robinkeunen, remytms and victor-champonnois Sep 13, 2023

carmenbianca requested review from huguesdk, remytms, robinkeunen and victor-champonnois September 13, 2023 14:23

carmenbianca commented Sep 15, 2023

View reviewed changes

Comment thread pos_customer_wallet/static/src/js/Screens/PaymentScreen/PaymentScreen.js Outdated

legalsylvain and others added 16 commits April 28, 2026 15:51

[REF] customer_wallet_pos: remove useless eslint disabling

f7a6fe2

co-authored-by: hugues de keyzer <odoo@hugues.info>

[FIX] customer_wallet_pos: compare float

ed72bec

[REF] customer_wallet_pos: replace var by const / let

c308c99

co-authored-by: hugues de keyzer <odoo@hugues.info>

[REF] update translation

ab50ab7

[IMP] customer_wallet*: improve readme

7c80f30

[IMP] customer_wallet: improve wizard buttons

02fe98d

* replace "save" and "discard" default buttons of the details wizard by a "close" button. * improve styling of the buttons of the redistribute wizard. * fix xml indentation.

[IMP] customer_wallet_portal: improve layout

5cd99d5

* fix alignment of amount and balance column values. * use t-else instead of opposite test. * replace t-esc by t-out.

[IMP] customer_wallet: make cosmetic code changes

65209d3

* rename model classes to match filename. * remove empty lines between field definitions.

[IMP] customer_wallet_pos: improve javascript code

2204de9

* simplify javascript code. * improve user messages. * replace t-esc by t-out.

[IMP] customer_wallet_pos: update roadmap

6fbf6f5

add known issue about sequence of operations to the roadmap.

[IMP] customer_wallet_portal: improve translation

d4f1b43

improve fr translation.

[IMP] customer_wallet_pos: improve user messages

9853121

[IMP] customer_wallet: correct user message

45e76ce

customer_wallet_pos: simplify css

355b443

use a more sober and simple styling to display the customer wallet amount on the pos payment screen.

[IMP] customer_wallet: format datetime in wizard

d6ec81c

format datetime as a date (since coming from account.move.line it has no time) (taking the locale into account) in the customer wallet detail wizard.

[IMP] customer_wallet*: update contributors

031c05f

huguesdk force-pushed the 16.0-mig-pos_customer_wallet branch from a77446d to 031c05f Compare April 28, 2026 14:33

github-grap-bot added series:16.0 mod:customer_wallet_pos Module customer_wallet_pos mod:customer_wallet_portal Module customer_wallet_portal mod:customer_wallet Module customer_wallet labels Apr 28, 2026

huguesdk approved these changes Apr 28, 2026

View reviewed changes

github-grap-bot added the bot is merging ⏳ label Apr 28, 2026

github-grap-bot merged commit 3fab367 into 16.0 Apr 28, 2026
2 checks passed

github-grap-bot deleted the 16.0-mig-pos_customer_wallet branch April 28, 2026 16:27

github-grap-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] pos_customer_wallet#300

[16.0][MIG] pos_customer_wallet#300
github-grap-bot merged 142 commits into16.0from
16.0-mig-pos_customer_wallet

carmenbianca commented Jul 11, 2023 •

edited

Loading

Uh oh!

codecov-commenter commented Sep 7, 2023 •

edited

Loading

Uh oh!

carmenbianca commented Sep 8, 2023

Uh oh!

Uh oh!

legalsylvain commented Sep 8, 2023

Uh oh!

Uh oh!

legalsylvain commented Sep 15, 2023

Uh oh!

carmenbianca commented Sep 18, 2023

Uh oh!

carmenbianca commented Sep 18, 2023

Uh oh!

huguesdk commented Apr 28, 2026

Uh oh!

github-grap-bot commented Apr 28, 2026

Uh oh!

Uh oh!

github-grap-bot commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

carmenbianca commented Jul 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Odoo task (if applicable)

Checklist before approval

Uh oh!

codecov-commenter commented Sep 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

carmenbianca commented Sep 8, 2023

Uh oh!

Uh oh!

legalsylvain commented Sep 8, 2023

Uh oh!

Uh oh!

legalsylvain commented Sep 15, 2023

Uh oh!

carmenbianca commented Sep 18, 2023

Uh oh!

carmenbianca commented Sep 18, 2023

Uh oh!

huguesdk commented Apr 28, 2026

Uh oh!

github-grap-bot commented Apr 28, 2026

Uh oh!

Uh oh!

github-grap-bot commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

carmenbianca commented Jul 11, 2023 •

edited

Loading

codecov-commenter commented Sep 7, 2023 •

edited

Loading