feat: Send upload size to upload request and cli version with API requests#702
Open
calvin-codecov wants to merge 2 commits intomainfrom
Open
feat: Send upload size to upload request and cli version with API requests#702calvin-codecov wants to merge 2 commits intomainfrom
calvin-codecov wants to merge 2 commits intomainfrom
Conversation
calvin-codecov
commented
Apr 22, 2026
Comment on lines
-269
to
-273
| mocked_legacy_upload_endpoint.match = [ | ||
| matchers.json_params_matcher(request_data), | ||
| matchers.header_matcher(headers), | ||
| ] | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This seems like it was incorrectly using the mocked_legacy_upload_endpoint even though this is a different endpoint. I think we want the mocked_test_results_endpoint (newly added below) which would match with the argument at line 295 and with the url designated in this function
calvin-codecov
commented
Apr 22, 2026
| commit_sha, | ||
| report_code, | ||
| upload_coverage, | ||
| file_not_found=file_not_found, |
Contributor
Author
There was a problem hiding this comment.
This seemed like a missed line from before. We weren't passing in the file_not_found value that is defined higher up at line 59/61 and self.get_url_and_possibly_update_data() takes it in with a default value of "False" so it would always just set `data['file_not_found'] to False
Please review this in particular
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/codecov/core-engineering/issues/31