SP-45: Add asset-registry validate command#342
Merged
Zgjim Haziri (ZgjimHaziri) merged 3 commits intomainfrom Apr 27, 2026
Merged
SP-45: Add asset-registry validate command#342Zgjim Haziri (ZgjimHaziri) merged 3 commits intomainfrom
Zgjim Haziri (ZgjimHaziri) merged 3 commits intomainfrom
Conversation
Zgjim Haziri (ZgjimHaziri)
force-pushed
the
SP-45-add-asset-registry-validate-command
branch
from
2f8aaaf to
8378d01
Compare
Base automatically changed from
SP-39-add-asset-registry-proxy-commands
to
main
April 17, 2026 13:35
Three mutually exclusive modes: - --configuration/-c: validate a configuration JSON before import - --nodeKey: validate an already-stored node on the platform - -f: provide a full ValidateRequest file (multi-node/advanced) The CLI assembles the ValidateRequest envelope in the first two modes. Update SKILL.md, agentic guide, and command docs. Includes-AI-Code: true Made-with: Cursor
Zgjim Haziri (ZgjimHaziri)
force-pushed
the
SP-45-add-asset-registry-validate-command
branch
from
8378d01 to
a90cb3e
Compare
Kastriot Salihu (ksalihu)
previously approved these changes
Apr 17, 2026
Zgjim Haziri (ZgjimHaziri)
requested review from
Buqeta (Buqeta) and
Meris Nici (promeris)
Meris Nici (promeris)
previously approved these changes
Apr 27, 2026
Buqeta (Buqeta)
previously approved these changes
Apr 27, 2026
The "save as JSON file" test asserted exact equality of the third
argument to fs.writeFileSync ({ encoding: "utf-8" }). On the GitHub
Actions runner, the per-file `jest.mock("fs", () => ...requireActual)`
factory in this spec interacts with jest.setup's mock such that the
captured args also include `mode: 384` (= 0o600), even though the
production code only passes `{ encoding: "utf-8" }`. The same call
captures only `encoding` locally on macOS.
Use `expect.objectContaining({ encoding: "utf-8" })` so the test
verifies the field we actually care about and is resilient to
runtime-injected options. Also restored the trailing newline on
asset-registry.service.ts.
Includes-AI-Code: true
Made-with: Cursor
Zgjim Haziri (ZgjimHaziri)
dismissed stale reviews from Buqeta (Buqeta) and Meris Nici (promeris)
via
d8cc16e
|
Buqeta (Buqeta)
approved these changes
Apr 27, 2026
Zgjim Haziri (ZgjimHaziri)
deleted the
SP-45-add-asset-registry-validate-command
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
asset-registry validatecommand with three mutually exclusive modes for validating asset configurations:--configuration/-cwith--packageKey: validate a configuration JSON before import (CLI builds the ValidateRequest envelope)--nodeKeywith--packageKey: validate an already-stored node on the platform-f: provide a file with the full ValidateRequest body (standalone alternative to all other options)Proxies to Pacman's
POST /core/asset-registry/validate/{assetType}endpoint.Ticket: SP-45
Depends on: #341
Test plan
content-cli asset-registry validate --helpoutput verified