feat: scaffold Marketplace app via sm CLI#123
Draft
antosubash wants to merge 2 commits intomainfrom
Draft
Conversation
Standalone SimpleModule app under marketplace/ with its own solution, package.json, and nuget.config pointing at nuget.org. Framework packages (SimpleModule.Core/.Database/.Hosting/.Generator) pinned at 0.0.33. Post-scaffold adjustments for living inside the SimpleModule monorepo: - Fixed Styles/app.css to resolve theme and source globs via node_modules and src/modules (the CLI template assumes a repo-root modules layout). - Added @tailwindcss/cli devDependency (required by SimpleModule.Hosting MSBuild target but missing from the CLI template). - Overrode nuget.config to nuget.org only (the CLI auto-adds an unused SimpleModule-Local feed when run inside the framework repo). - Added empty Directory.Build.targets to stop MSBuild inheriting the outer repo's targets. - Set "root": false in biome.json since the outer repo already has a Biome root config. - Local .gitignore for tailwind/vite build outputs.
Deploying simplemodule-website with
|
| Latest commit: |
e930633
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8f879c44.simplemodule-website.pages.dev |
| Branch Preview URL: | https://claude-setup-marketplace-sca.simplemodule-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimpleModule.Clias a local dotnet tool from nuget.org (added to.config/dotnet-tools.jsonalongsidecsharpier).marketplace/viadotnet sm new project Marketplace, then renamed the folder to lowercase. The app has its ownMarketplace.slnx,package.json,nuget.config, and npm workspace — fully separate from the framework repo.SimpleModule.Core/.Database/.Hosting/.Generator) are pinned at 0.0.33 (latest published on nuget.org at scaffold time) and restore cleanly from nuget.org.Post-scaffold adjustments
A few fixes were needed to make the scaffold build cleanly while living inside this repo:
marketplace/src/Marketplace.Host/Styles/app.css— rewrote imports/globs. The CLI template assumes a repo-rootmodules/layout (../../../../modules/**) and a localpackages/folder. Corrected to resolve@simplemodule/theme-default/theme.cssand the UI/client sources fromnode_modules, and to scan this app's ownsrc/modules/**.marketplace/package.json— added@tailwindcss/clidevDependency. TheSimpleModule.HostingMSBuild target shells out tonode_modules/.bin/tailwindcss, which the CLI template forgot to include.marketplace/nuget.config— stripped the auto-addedSimpleModule-Localfeed (points to a path that doesn't exist when we're only using nuget.org). Left onlynuget.orgwith<clear />.marketplace/Directory.Build.targets— empty<Project />file so MSBuild doesn't walk up and inherit the outer repo's targets.marketplace/biome.json— set"root": falseso Biome doesn't error on nested root configs.marketplace/.gitignore— ignorewwwroot/{js,css/app.css}andStyles/_scan/build outputs.Test plan
dotnet tool restore— installssmlocallycd marketplace && dotnet restore— restores framework packages 0.0.33 from nuget.orgdotnet build -c Debug— builds clean (0 warnings, 0 errors) incl. Tailwind + Vitenpm install— resolves@simplemodule/*viafile:links to the outer repo'spackages/dotnet run --project src/Marketplace.Host— browse https://localhost:5001 and confirm the Inertia Welcome page renders (run locally; not exercised in this branch)Generated by Claude Code