Skip to content

Remove 'setuptools' from install_requires in awxkit setup.py#16442

Open
Rakesh-git-2 wants to merge 1 commit intoansible:develfrom
Rakesh-git-2:issue-16378-awxkit-fix
Open

Remove 'setuptools' from install_requires in awxkit setup.py#16442
Rakesh-git-2 wants to merge 1 commit intoansible:develfrom
Rakesh-git-2:issue-16378-awxkit-fix

Conversation

@Rakesh-git-2
Copy link
Copy Markdown

@Rakesh-git-2 Rakesh-git-2 commented May 3, 2026

Summary

  • Removes setuptools from the install_requires list in awxkit/setup.py
  • setuptools is a build/packaging tool, not a runtime dependency, so it should not be listed under install_requires

Test plan

  • Verify pip install awxkit succeeds without setuptools being explicitly installed
  • Confirm awxkit functionality is unaffected (no runtime import of setuptools)

Fixes #16378

Summary by CodeRabbit

  • Chores
    • Removed an unnecessary dependency from package installation requirements.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 5b1dbc05-c000-4d3b-b597-ad91fadfb199

📥 Commits

Reviewing files that changed from the base of the PR and between 83f60cd and 21a9727.

📒 Files selected for processing (1)
  • awxkit/setup.py
💤 Files with no reviewable changes (1)
  • awxkit/setup.py

📝 Walkthrough

Walkthrough

The awxkit/setup.py file removes setuptools from the package's install_requires dependency list. This is a single-line removal with no changes to setup metadata, signatures, or other configuration.

Changes

Dependency Update

Layer / File(s) Summary
Package Dependencies
awxkit/setup.py
Remove setuptools from the install_requires list; the dependency array now begins with PyYAML and requests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly matches the main change: removing setuptools from install_requires in awxkit/setup.py.
Linked Issues check ✅ Passed The PR removes setuptools from install_requires, addressing issue #16378's root cause of deprecating pkg_resources dependency.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to removing setuptools from dependencies as required by issue #16378, with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

awxkit - requires deprecated pkg_resources

1 participant