fix(csharp): re-enable CanExecuteQuery tests for SEA protocol (PECO-3006)#428
Merged
eric-wang-1990 merged 1 commit intomainfrom May 7, 2026
Merged
Conversation
eric-wang-1990
requested review from
gopalldb,
lidavidm,
msrathore-db and
vikrantpuppala
as code owners
eric-wang-1990
force-pushed
the
fix/peco-3006-sea-session-catalog-schema-context
branch
2 times, most recently
from
8b72057 to
6d9409b
Compare
msrathore-db
approved these changes
May 5, 2026
| // TODO: PECO-3006 - SEA CanExecuteQuery returns 0 rows | ||
| protected override void ValidateCanExecuteQuery(double? batchSizeFactor) | ||
| { | ||
| Skip.If(TestConfiguration.Protocol == "rest", "SEA CanExecuteQuery returns 0 rows (PECO-3006)"); |
Collaborator
There was a problem hiding this comment.
Are these changes expected to be a part of the PR?
eric-wang-1990
force-pushed
the
fix/peco-3006-sea-session-catalog-schema-context
branch
from
6d9409b to
97a26eb
Compare
eric-wang-1990
changed the title
…006) SEA CanExecuteQuery, CanExecuteQueryAsync, and CanClientExecuteQuery were skipped on the REST protocol path with a TODO noting 0 rows returned. The underlying issue has since been resolved; remove the Skip.If guards so these tests run on both Thrift and SEA. Closes #NNN
eric-wang-1990
force-pushed
the
fix/peco-3006-sea-session-catalog-schema-context
branch
from
97a26eb to
5e72814
Compare
eric-wang-1990
deleted the
fix/peco-3006-sea-session-catalog-schema-context
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"default"when no schema is specified in SEA (REST) connections, matching the Thrift protocol behaviorJira
Fixes PECO-3006
Test plan
SetDefaultCatalogAndSchemaOptionsTestcovers the schema context behaviorCanExecuteQueryandCanExecuteQueryAsyncshould now return correct row counts for SEA🤖 Generated with Claude Code