Skip to content

fix: fix adding safe-directory in container#2418

Open
marcus-wirtz-snkeos wants to merge 2 commits intoactions:mainfrom
marcus-wirtz-snkeos:fix/safe-directoy
Open

fix: fix adding safe-directory in container#2418
marcus-wirtz-snkeos wants to merge 2 commits intoactions:mainfrom
marcus-wirtz-snkeos:fix/safe-directoy

Conversation

@marcus-wirtz-snkeos
Copy link
Copy Markdown

@marcus-wirtz-snkeos marcus-wirtz-snkeos commented Apr 21, 2026

solves issue #2031

Copilot AI review requested due to automatic review settings April 21, 2026 09:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix safe.directory handling so git operations work reliably when the checked-out repository is accessed from container environments (e.g., /github/workspace), by adding the container-mapped path as an additional safe directory.

Changes:

  • Capture GITHUB_WORKSPACE on inputs and plumb it through settings.
  • Update checkout flow to add safe.directory for both the host repository path and the container workspace path.
  • Remove test/workflow hacks that globally set safe.directory=*.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/input-helper.ts Stores resolved GITHUB_WORKSPACE into settings for later container-path calculations.
src/git-source-settings.ts Adds githubWorkspacePath to the settings interface.
src/git-source-provider.ts Adds helper functions to compute container repo path and to add multiple safe.directory entries.
test/verify-worktree.sh Removes blanket global safe.directory=* to rely on action behavior.
.github/workflows/test.yml Removes blanket global safe.directory=* in the container test job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/git-source-provider.ts
Comment thread src/git-source-provider.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants