fix: fix adding safe-directory in container#2418
Open
marcus-wirtz-snkeos wants to merge 2 commits intoactions:mainfrom
Open
fix: fix adding safe-directory in container#2418marcus-wirtz-snkeos wants to merge 2 commits intoactions:mainfrom
marcus-wirtz-snkeos wants to merge 2 commits intoactions:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix safe.directory handling so git operations work reliably when the checked-out repository is accessed from container environments (e.g., /github/workspace), by adding the container-mapped path as an additional safe directory.
Changes:
- Capture
GITHUB_WORKSPACEon inputs and plumb it through settings. - Update checkout flow to add
safe.directoryfor both the host repository path and the container workspace path. - Remove test/workflow hacks that globally set
safe.directory=*.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/input-helper.ts | Stores resolved GITHUB_WORKSPACE into settings for later container-path calculations. |
| src/git-source-settings.ts | Adds githubWorkspacePath to the settings interface. |
| src/git-source-provider.ts | Adds helper functions to compute container repo path and to add multiple safe.directory entries. |
| test/verify-worktree.sh | Removes blanket global safe.directory=* to rely on action behavior. |
| .github/workflows/test.yml | Removes blanket global safe.directory=* in the container test job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves issue #2031